Refine presence labels and status colors - #323
klopez4212 wants to merge 1 commit into
Conversation
Signed-off-by: klopez4212 <klopez4212@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b96ce7aed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| **Away**, and **Appear offline**, using the shared keyboard-accessible radio group. | ||
| Automatic returns to Active on input/foreground return and Away after ten idle | ||
| minutes. Manual Away/Offline wins over typing until Automatic is selected. | ||
| relay readback. Its account dropdown keeps Settings and offers **Online**, |
There was a problem hiding this comment.
Commit f60680d0b9df17c8a8fe8294f24bcd6520e2d6bf has no Signed-off-by trailer, so it violates the repository's requirement that every PR commit carry DCO certification and will fail the hosted DCO check. Recreate the commit with git commit --signoff using the actual author's verified identity before submitting it.
AGENTS.md reference: AGENTS.md:L151-L161
Useful? React with 👍 / 👎.
wesbillman
left a comment
There was a problem hiding this comment.
Star Lord’s automated source review, published through Wes’s account.
One actionable P2 finding in the inline comment: the shared palette change leaves the design-viewer browser regression asserting the old colors. Minimalness/elegance: 9/10; correctness including retained regression coverage: 8/10 until that mismatch is repaired. This is a non-blocking COMMENT review, not approval or a merge decision.
Reviewed head 9b96ce7aed2bf7e62b297e7d50b156036e5d969e against base 3e0a4087b9c09df911f080a3c3a3534d5d7bffab (15 changed files). Traced the profile menu through the existing presence activity owner, Base UI 1.8.0 radio selection behavior, shared Button/Avatar styling, contrast-exception guard and affected test consumers. The explicit manual statuses and internal automatic mode reuse the existing owner. I am preserving the documented, human-accepted contrast exceptions rather than reopening that design decision; they still do not establish WCAG/APCA compliance.
Validation limits: source-only; no tests, builds, app/PR-code execution, or CI inspection. The stale browser assertion is demonstrated by the source mapping, not a locally observed test failure. Author-reported checks and human approval were not independently exercised. Native/live-account behavior and current hosted CI remain unverified.
| --status-online: var(--green-10); | ||
| --status-away: var(--amber-10); |
There was a problem hiding this comment.
[P2] Update the design-viewer badge assertions with the shared palette
These role mappings also drive the real Avatar specimens, but tests/fixtures/design-system/viewer.spec.ts:66–84 still asserts Green 11 / Amber 11 in both themes. Its first light-mode Online assertion expects rgb(33, 131, 88), while this change resolves to rgb(43, 154, 102) through .buzz-avatar-status-dot in styles/components.css:344–357; Away and the dark-mode pairs are stale too. Consequently the retained status-badge case in design:test:browser cannot pass against this revision in either configured engine. Update all four expected Online/Away colors to the approved step-ten values, preserving the cutout/size/state assertions, and validate the affected viewer file in Chromium and WebKit. This is a source-demonstrated test regression, not a request to revert the accepted palette.
The profile menu now offers Online, Away, and Offline, with a Medium availability capsule whose colors match the presence palette. The checked option follows effective status; default and saved automatic activity detection remain internal, while explicit selections persist as manual overrides.
Online uses Green 10; Away uses Amber 10 for dots/fills and Amber 12 for label text. Online and Offline fills use the inset surface. Dropdown text remains Regular, and the shared controls retain their keyboard behavior.
Accepted contrast limitations
The human explicitly chose to preserve this appearance after reviewing the contrast shortfalls. Online text remains below WCAG 4.5:1 in light mode (2.51–2.87:1) and below APCA Lc60 in both themes. The light Away dot remains below the 3:1 boundary target (1.568–1.709:1).
Following the design system's documented exception policy, the contrast guard reports four exact light-mode Away exceptions, bound to the role, surface, and resolved foreground/background colors. Regression tests prove that changed colors, changed surfaces, and dark-mode pairings still fail. Other thresholds and checks remain active. A passing guard does not establish contrast compliance. Full measurements and the Online text exception are recorded in docs/presence.md.
Validation
buzz-review-completed
Screenshots
Sample identities in the production-component browser fixture; no live account.