Skip to content

test(relay): expect aggregate workflow reads in 501-channel discovery - #362

Closed
loganj wants to merge 1 commit into
mainfrom
larry/fix-store-discovery-main
Closed

test(relay): expect aggregate workflow reads in 501-channel discovery#362
loganj wants to merge 1 commit into
mainfrom
larry/fix-store-discovery-main

Conversation

@loganj

@loganj loganj commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🤖

Summary

  • Main fails the JavaScript job: one test in store-discovery.test.ts checks how the app asks the relay for workflows across many channels, and it expected the old request shape.
  • This change updates that test to expect the current shape. It changes no app code.

Details

Larry
test(relay): expect aggregate workflow reads in 501-channel discovery
c6c7db7 
#325 changed batched workflow definition reads to one aggregate filter
per batch. #326 landed a test that still expected one filter per
channel, so main fails store-discovery.test.ts. Assert the aggregate
filter shape; the reader sorts tag values.

Signed-off-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
@loganj
loganj marked this pull request as ready for review September 28, 2026 20:10
@loganj
loganj requested review from a team, comp615 and wesbillman as code owners September 28, 2026 20:10
wesbillman
wesbillman reviewed Sep 28, 2026
View reviewed changes

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Star Lord automated source review

Published through Wes’s GitHub account. No actionable findings. This is a minimal assertion-only correction; no application behavior changes.

The expected single kind-30620 filter with the whole channel batch and WORKFLOW_DEFINITION_LIMIT matches workflows/capability.ts:411–420. Sorting a copied batch matches the shared reader’s set canonicalization in relay/reader.ts:213–235 without mutating the batch. The 501 signed, same-timestamp memberships, second-page workflow result, full name/roster checks, final empty request queue, and view disposal remain intact. The change strengthens the request-shape assertion rather than dropping the cross-page behavior check.

Revision and evidence

  • Head: c6c7db7cf9d8d2f9b027740bb83e932d81aa6e10
  • Base/merge base: 1f71ee94f2dadb743a6529ded436b266e3c93045
  • Source-only: no tests/builds, installs, PR-code execution or app launches by this reviewer. Exact base-to-head comparison confirms only the import and filter assertion changed.
  • One hosted CI snapshot at this head showed CI required, JavaScript, Rust/tool integration, all six browser shards, browser measurements, security checks and DCO passing; Windows native validation was skipped. These are hosted results, not a local test run or independent live-relay/native acceptance.

COMMENT only—not approval or merge authorization.

@loganj

loganj commented Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

Superseded: #359 (3899de3) landed the same test fix on main, and main CI passed at 3899de3. Closing.

@loganj loganj closed this Sep 28, 2026
@loganj
loganj deleted the larry/fix-store-discovery-main branch September 28, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesbillman wesbillman wesbillman left review comments
@comp615 comp615 Awaiting requested review from comp615 comp615 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loganj @wesbillman