Open pages from search by keyboard once the palette is final

[loganj]

🤖

Summary

• Many browser tests open a page through the Search Buzz dialog ("Messages", "Projects" and so on) with a shared helper, openPage. It clicked the action by its position on screen. Sometimes the click missed, the dialog stayed open, and the test failed. CI recently showed this in thread-unread.spec.mjs on WebKit.
• Why it missed: after a reload that restores a conversation, the dialog opens before the channel list has loaded. When the list arrives, "This conversation" and "Recent activity" rows appear above Actions and push every action down about 190px. A click at the old position lands between rows.
• Now the helper selects the action with the keyboard and presses Enter. The dialog tracks the selected action by its identity, not its position, so rows arriving later cannot move the selection. Keyboard users already navigate this way.
• Test-only change. No app code changes.

Details

• The dialog also starts as a placeholder ("Connecting to this community…") until the community connects, then the full dialog replaces it. That swap resets the selection, so the helper waits for the full dialog first. Two tests hold or fail the relay connection on purpose, so the placeholder stays. They pass openPage(page, name, { connected: false }), and the helper checks that the placeholder is showing.
• The old helper waited for the dialog's opening animation before clicking. The keyboard path does not depend on hit targets, so that wait is removed.
• New test in global-search.spec.mjs: it holds the channel-membership read (the relay query that lists your channels) across a reload so the rows arrive after an action is selected. It checks that the action moved and is still selected, then presses Enter and checks that the page opened.
• Product note, not changed here: a mouse user can hit the same miss if they click just as the rows arrive. Reserving space for those sections, or not moving existing rows, would fix it for users too. That is a design decision, so it is left for a separate change.

[kalvinnchau]

🤖 Reviewed the test-only change at ef2d98d against 3a19fa4; no findings. Review performed by am using Kalvin’s GitHub credentials at his explicit request.