Skip to content

test(agents): pause the status poll around the failed-Stop checks #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wesbillman merged 2 commits into from
Sep 29, 2026
Merged

test(agents): pause the status poll around the failed-Stop checks #431

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22cb474
test(agents): pause the status poll around the failed-Stop checks
Sep 29, 2026
e2cf727
test(agents): pause the status poll at fixed clock instants
Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/browser/agent-control.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,9 @@ for (const previouslyStopped of [false, true]) {
});
await server.listen();
try {
// Install before the five-second status poll exists; paused below at a
// fixed instant beyond this test's timeout, never runner "now".
await page.clock.install({ time: new Date("2026-01-01T00:00:00Z") });
await page.goto(
`http://127.0.0.1:${server.httpServer.address().port}/tests/fixtures/agent-control.html`,
);
Expand Down Expand Up @@ -395,6 +398,9 @@ for (const previouslyStopped of [false, true]) {
(call) => call.action !== "snapshot",
),
);
// From here only explicit actions may read or write: a poll tick would
// replace the failed Stop's guidance, or recover before the explicit retry.
await page.clock.pauseAt(new Date("2026-01-01T01:00:00Z"));
await stop.click();
await expect(page.getByRole("alert")).toContainText(
"could not persist disabled settings",
Expand Down
Loading