fix(shell): remove sidebar toggle render and animation delays - #475
Conversation
Hiding or showing the sidebar changed AppShell state and rebuilt the sidebar element inline, so every toggle synchronously re-rendered the whole channel sidebar before the first frame. Memoize the navigation element on the inputs it reads so toggle-only renders skip the sidebar subtree. Signed-off-by: cid <d9f92a72922bf45c17379a47d64dae84b6020397c2d5a52b5317d512068cd9d3@buzz.block.builderlab.xyz>
The collapsible navigation animated max-width from a container-relative ceiling far wider than the sidebar, so hiding held still for the first half of the transition and showing finished early. The sidebar also narrowed to its minimum while moving, re-measuring every row each frame. Animate a single grid track between 1fr and 0fr instead, which runs from the sidebar's actual extent to zero, and hold the sidebar at its own width until it is fully expanded. Tighten the geometry test to require early, midpoint and monotonic motion with a constant sidebar width, and make the AppShell test isolate selection changes. Signed-off-by: cid <d9f92a72922bf45c17379a47d64dae84b6020397c2d5a52b5317d512068cd9d3@buzz.block.builderlab.xyz>
Preserve the test-only fix from cid’s unpublished amend as a fast-forward addition to the published PR. Signed-off-by: cid <d9f92a72922bf45c17379a47d64dae84b6020397c2d5a52b5317d512068cd9d3@buzz.block.builderlab.xyz> Signed-off-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>
wesbillman
left a comment
There was a problem hiding this comment.
Two changes requested: the clamped-width transition issue noted inline, plus this public-material issue:
- [P2] Remove private coordination identifiers from “Origin”. This public PR description includes an internal Buzz channel identifier/name and thread event identifier. Remove those references, or replace them with a public issue/context summary; retain legitimate contributor attribution.
Star Lord automated source review via Wes’s account (wesbillman). Head ad386a86b4a9744eb11bf212b054b9306389f72a; base 73064e34dfa5f14c472c3661589d05f509c17884. Source-only: no tests, app execution, or visual/native validation. One hosted-check snapshot still had jobs running; the description’s hook evidence is for an earlier head. No attached images were present.
Signed-off-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>
wesbillman
left a comment
There was a problem hiding this comment.
One change remains: remove the private coordination identifiers from Origin, as requested in the previous review. That public-material finding is still unresolved.
The sidebar clamp correction addresses the earlier source defect: its width cap now comes from the stable shell rather than the animated track. The extended geometry assertions cover the clamped case; no new production defect found in this follow-up.
Star Lord’s automated source review via Wes’s account. Head d44724d47b604ee8a93c79c4934f0bce01ffdd8a; base 73064e34dfa5f14c472c3661589d05f509c17884. Source-only; no tests/app executed. Hosted CI/DCO passed at snapshot; Windows validation skipped, and human/native acceptance of this correction remains unverified. COMMENT only, not approval.
…followup * origin/main: fix(shell): remove sidebar toggle render and animation delays (#475) Fix unread catch-up and reading focus (#470) Refine shared surfaces, contrast, and relative UI sizing (#458) Signed-off-by: Tree Trunks <6ba22921d9dc2ad0aa6ecdf63787ddd24726e266d866da31af69f2e4e146ace5@buzz.block.builderlab.xyz> # Conflicts: # src/shared/design-system/styles/tokens.css # src/shared/styles/globals.css
Summary
Validation
Clamp-comment follow-up