Skip to content

fix(ci): publish versioned Docker tags via auto-tag dispatch #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wpfleger96 wants to merge 1 commit into from
Closed

fix(ci): publish versioned Docker tags via auto-tag dispatch #1154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/auto-tag-on-release-pr-merge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,15 @@ jobs:
gh workflow run release.yml \
-f version="$VERSION" \
-f ref="v$VERSION"

- name: Trigger Docker image build
# docker.yml's on:push:tags trigger never fires for this tag because
# the tag was pushed with GITHUB_TOKEN (recursion guard). Dispatch it
# explicitly with version+ref, same as the release build above.
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
VERSION: ${{ env.version }}
run: |
gh workflow run docker.yml \
-f version="$VERSION" \
-f ref="v$VERSION"
36 changes: 29 additions & 7 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,18 @@ name: Docker image
# - push to main → :main + :sha-<7>
# - push tags v*.*.* → :latest + :{version} + :{major}.{minor} + :{major}
# - pull_request → build only (no push), cache stays warm
# - workflow_dispatch → manual canary
# - workflow_dispatch → manual canary, or release-tag dispatch with
# version+ref inputs (auto-tag rescues the dead
# push:tags trigger this way — see below)
#
# Why workflow_dispatch carries version/ref inputs:
# auto-tag-on-release-pr-merge.yml pushes the release tag with the default
# GITHUB_TOKEN, which GitHub deliberately does NOT let fire on:push triggers
# (recursion guard). So the push:tags trigger above never runs for releases.
# auto-tag instead dispatches this workflow with the version + tag ref, the
# same rescue release.yml already uses. On dispatch github.ref is `main`, so
# the tag ref must be plumbed through explicitly: checkout pins to inputs.ref,
# and the semver tags take inputs.version via metadata-action `value=`.

on:
push:
Expand All @@ -33,6 +44,14 @@ on:
- "pnpm-workspace.yaml"
- "patches/**"
workflow_dispatch:
inputs:
version:
description: "Semver version e.g. 0.3.26 (no v prefix) — for tag-release dispatch"
required: false
ref:
description: "Tag/branch/SHA to build, e.g. v0.3.26"
required: false
default: main

# One image build per ref; cancel superseded PR builds, but never cancel
# tag/main builds (publishing must not be aborted mid-flight).
Expand Down Expand Up @@ -77,6 +96,9 @@ jobs:
- name: Checkout
uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
with:
# On workflow_dispatch (release-tag rescue) build the tagged commit,
# not main. Empty string = default ref for push/PR events.
ref: ${{ github.event_name == 'workflow_dispatch' && inputs.ref || '' }}
persist-credentials: false

- name: Set up Docker Buildx
Expand Down Expand Up @@ -108,9 +130,9 @@ jobs:
tags: |
type=ref,event=branch
type=sha,prefix=sha-,format=short
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
type=semver,pattern={{major}}
type=semver,pattern={{version}},value=${{ inputs.version }}
type=semver,pattern={{major}}.{{minor}},value=${{ inputs.version }}
type=semver,pattern={{major}},value=${{ inputs.version }}
type=raw,value=latest,enable={{is_default_branch}}
labels: |
org.opencontainers.image.title=Buzz
Expand Down Expand Up @@ -189,9 +211,9 @@ jobs:
tags: |
type=ref,event=branch
type=sha,prefix=sha-,format=short
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
type=semver,pattern={{major}}
type=semver,pattern={{version}},value=${{ inputs.version }}
type=semver,pattern={{major}}.{{minor}},value=${{ inputs.version }}
type=semver,pattern={{major}},value=${{ inputs.version }}
type=raw,value=latest,enable={{is_default_branch}}

- name: Create and push manifest list
Expand Down