Fix desktop onboarding regressions - #7659
Conversation
Signed-off-by: kenny lopez <klopez4212@gmail.com>
🔐 Codex Security Review
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jedwards27
left a comment
There was a problem hiding this comment.
Review verdict: APPROVE
Reviewed exact head 745a51cd26d57500feef26f269a6e17849802479 against base f78a32cf03aa90b0da36b44d075daecd8f85d7d8.
No author-actionable defects were established across systems/integration and product/UI review.
The changed contracts are coherent:
buzz-agentselection routes directly to provider configuration without waiting for generic runtime discovery. The parent freezes the selected handoff, so late discovery cannot replace the explicit choice; provider credentials are still validated before completion.- Signed-out and alternate-harness paths preserve the direct Buzz route while retaining readiness/auth/install handling for other runtimes and a recoverable Back path.
- Runtime ordering groups all available entries before unavailable entries, matching the renderer's single-divider ownership.
- The private key is intentionally fetched and rendered on mount, then blurred on hover/focus while exposing an explicit Copy control. Clipboard access remains click-only, and initial read failures remain retryable. The increased renderer/DOM exposure is the declared reveal-first product behavior, not an accidental bypass.
Verification
At the exact head:
- Desktop JS suite:
6,501/6,501passed pnpm typecheck: passedpnpm check: passed (exit 0; informational/warning output only)pnpm build: passedgit diff --check: passed- GitHub Desktop Core, all four Desktop Smoke E2E shards, Windows build, macOS build, Desktop E2E integration, Semgrep, zizmor, and DCO checks: completed successfully
One attempted local Playwright run was discarded as invalid evidence because it used a normal build rather than the required E2E build recipe; it is not treated as a PR failure.
Residual confidence gap: the review did not independently complete native/browser visual and accessibility interaction observation. Author action: none. Verification owner: reviewer/native tooling. Existing exact-head CI is green.
…eway-origin * origin/main: Fix desktop onboarding regressions (#7659) Deduplicate thread context by ACP session delivery (#7620) feat(mobile): hard-block under-18 users on the store age signal (#4665) Document incoming Buzz turn structure (#7624) Refresh desktop onboarding flow (#7528) Signed-off-by: Tom Brow <tomb@block.xyz>
…ush-cache-offload * commit '41c5ace93740261ee5a5d962c2a17e8d846c2c1b': perf(mobile): move profile sig checks off main thread (#7648) perf(mobile): avoid redundant message list sorting (#7647) perf(mobile): avoid reparsing unchanged Markdown (#7649) Fix desktop onboarding regressions (#7659) Deduplicate thread context by ACP session delivery (#7620) feat(mobile): hard-block under-18 users on the store age signal (#4665) Document incoming Buzz turn structure (#7624) Refresh desktop onboarding flow (#7528) Fix Apple Silicon iOS simulator builds (#7646) Signed-off-by: Tom Brow <tomb@block.xyz>
Summary
Testing
pnpm checkpnpm test(6,501 passed)