Skip to content

Fix desktop onboarding regressions - #7659

Merged
klopez4212 merged 1 commit into
mainfrom
kennylopez-onboarding-visual-regressions
Sep 15, 2026
Merged

klopez4212 merged 1 commit into
mainfrom
kennylopez-onboarding-visual-regressions

Conversation

@klopez4212

Copy link
Copy Markdown
Contributor

Summary

  • restore neutral identity guidance icons and reveal-first private-key copying
  • keep runtime availability sections contiguous and restore primary onboarding colors
  • route API-key setup directly to Buzz provider configuration, including slow discovery and signed-out states

Testing

  • pnpm check
  • pnpm test (6,501 passed)
  • focused Playwright onboarding coverage (API routing 3/3; visual flow 1/1)

Signed-off-by: kenny lopez <klopez4212@gmail.com>
@klopez4212
klopez4212 requested a review from a team as a code owner September 15, 2026 13:48
@github-actions

Copy link
Copy Markdown

🔐 Codex Security Review

Status: review required for the current range.

The current range is f78a32cf03aa90b0da36b44d075daecd8f85d7d8...745a51cd26d57500feef26f269a6e17849802479.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review 745a51cd26d57500feef26f269a6e17849802479 to authorize a new review.
Any previous review applies only to its recorded range.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-15T13:53:31.768866Z 745a51c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jedwards27 jedwards27 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review verdict: APPROVE

Reviewed exact head 745a51cd26d57500feef26f269a6e17849802479 against base f78a32cf03aa90b0da36b44d075daecd8f85d7d8.

No author-actionable defects were established across systems/integration and product/UI review.

The changed contracts are coherent:

  • buzz-agent selection routes directly to provider configuration without waiting for generic runtime discovery. The parent freezes the selected handoff, so late discovery cannot replace the explicit choice; provider credentials are still validated before completion.
  • Signed-out and alternate-harness paths preserve the direct Buzz route while retaining readiness/auth/install handling for other runtimes and a recoverable Back path.
  • Runtime ordering groups all available entries before unavailable entries, matching the renderer's single-divider ownership.
  • The private key is intentionally fetched and rendered on mount, then blurred on hover/focus while exposing an explicit Copy control. Clipboard access remains click-only, and initial read failures remain retryable. The increased renderer/DOM exposure is the declared reveal-first product behavior, not an accidental bypass.

Verification

At the exact head:

  • Desktop JS suite: 6,501/6,501 passed
  • pnpm typecheck: passed
  • pnpm check: passed (exit 0; informational/warning output only)
  • pnpm build: passed
  • git diff --check: passed
  • GitHub Desktop Core, all four Desktop Smoke E2E shards, Windows build, macOS build, Desktop E2E integration, Semgrep, zizmor, and DCO checks: completed successfully

One attempted local Playwright run was discarded as invalid evidence because it used a normal build rather than the required E2E build recipe; it is not treated as a PR failure.

Residual confidence gap: the review did not independently complete native/browser visual and accessibility interaction observation. Author action: none. Verification owner: reviewer/native tooling. Existing exact-head CI is green.

@klopez4212
klopez4212 merged commit a9dd4d3 into main Sep 15, 2026
57 checks passed
@klopez4212
klopez4212 deleted the kennylopez-onboarding-visual-regressions branch September 15, 2026 14:30
baxen added a commit that referenced this pull request Sep 15, 2026
…ey-client

* origin/main:
  Fix desktop onboarding regressions (#7659)
  Deduplicate thread context by ACP session delivery (#7620)
  feat(mobile): hard-block under-18 users on the store age signal (#4665)

Signed-off-by: Bradley Axen <baxen@squareup.com>
brow added a commit that referenced this pull request Sep 15, 2026
…eway-origin

* origin/main:
  Fix desktop onboarding regressions (#7659)
  Deduplicate thread context by ACP session delivery (#7620)
  feat(mobile): hard-block under-18 users on the store age signal (#4665)
  Document incoming Buzz turn structure (#7624)
  Refresh desktop onboarding flow (#7528)

Signed-off-by: Tom Brow <tomb@block.xyz>
brow added a commit that referenced this pull request Sep 15, 2026
…ush-cache-offload

* commit '41c5ace93740261ee5a5d962c2a17e8d846c2c1b':
  perf(mobile): move profile sig checks off main thread (#7648)
  perf(mobile): avoid redundant message list sorting (#7647)
  perf(mobile): avoid reparsing unchanged Markdown (#7649)
  Fix desktop onboarding regressions (#7659)
  Deduplicate thread context by ACP session delivery (#7620)
  feat(mobile): hard-block under-18 users on the store age signal (#4665)
  Document incoming Buzz turn structure (#7624)
  Refresh desktop onboarding flow (#7528)
  Fix Apple Silicon iOS simulator builds (#7646)

Signed-off-by: Tom Brow <tomb@block.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants