AIDA-1977: Preserve replies after failed sends - #7671
Draft
ngthuydiem wants to merge 1 commit into
Draft
ngthuydiem wants to merge 1 commit into
ngthuydiem wants to merge 1 commit into
Conversation
Signed-off-by: Diem Nguyen <diem@squareup.com>
🔐 Codex Security Review
|
ngthuydiem
added a commit
that referenced
this pull request
Sep 15, 2026
Signed-off-by: Diem Nguyen <diem@squareup.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a Desktop send fails, its rollback restores an earlier conversation snapshot. Messages received while that send was pending disappear, and overlapping sends can erase or resurrect each other.
Remove only the failed send's optimistic row from the current timeline and channel window. Preserve incoming messages, separate thread caches, history pages, and other pending sends.
Related issue
Partial fix for AIDA-1977. This addresses messages that arrive and then disappear after a failed send. It does not change how agents publish final answers.
Closest related work: #7249, which proposes harness publication of Activity-only answers and touches a different path.
Testing
Built Desktop with its isolated mock bridge, held an outgoing send, delivered an incoming result, then released a terminal relay rejection. The result disappears on the base build. The fixed build preserves it through rejection and navigation in both repetitions.
Command:
pnpm build:e2e && pnpm exec playwright test --project=smoke failed-send-preserves-replies.spec.ts --repeat-each=2.Validated in Chromium on macOS with synthetic accounts and a mock relay. Native Windows and a real agent/relay reconnect were not exercised.
Before: incoming result disappears
After: incoming result remains
Known validation gaps
The full local
just cirun is not green: it stopped at ACP unit tests outside this Desktop change. The inherited owner-only configuration explains one failure; timing and steering failures remain unresolved. Native runtime acceptance remains pending.Generated with Codex