Skip to content

Show active thread count for agents - #7901

Closed
salman1993 wants to merge 2 commits into
mainfrom
codex/thread-agent-activity-count
Closed

salman1993 wants to merge 2 commits into
mainfrom
codex/thread-agent-activity-count

Conversation

@salman1993

@salman1993 salman1993 commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

An agent with the thread session policy can work in several threads in one channel. The channel composer showed one recent activity headline for that agent, which could describe the wrong thread. It now says “Caddie is working on 2 threads now” when two thread sessions are active. With one thread, it keeps the existing headline.

The harness sends the canonical thread root on turn start and liveness events. Desktop counts distinct active roots and updates the label as turns start or finish. Channel-policy agents and the thread reply composer keep their current labels.

Related issue

None found for this thread count behavior.

Testing

  • just ci passed after the review changes.
  • A run_prompt_task test checks that thread scopes emit their root and conversation scopes omit it.
  • Desktop store and composer tests cover distinct roots, an initially unknown root, and the one-thread fallback. The mock-bridge screenshots below show the one-thread and two-thread states.

The count appears only when every active turn in the channel has a thread root. Older observer frames keep the existing activity headline until an updated harness supplies those roots. A live relay and agent check remains for review before marking this PR ready.

Generated with Codex

Signed-off-by: Salman Mohammed <smohammed@squareup.com>
@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

🔐 Codex Security Review

Status: review required for the current range.

The current range is a1fb6645d994e72b5f39fae8bd482d400e4005b6...729f2897856a0155999daa80169810bda96f55c7.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review 729f2897856a0155999daa80169810bda96f55c7 to authorize a new review.
Any previous review applies only to its recorded range.

@salman1993

Copy link
Copy Markdown
Contributor Author

🤖 Composer activity with one and two active thread sessions.

One active thread

The current activity headline remains.

01-one-thread

Two active threads

The channel composer shows the distinct active thread count.

02-two-threads

@salman1993
salman1993 marked this pull request as ready for review September 25, 2026 20:43
@salman1993
salman1993 requested a review from a team as a code owner September 25, 2026 20:43
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-09-25T23:09:30.896496Z 729f289 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Signed-off-by: Salman Mohammed <smohammed@squareup.com>
@salman1993
salman1993 marked this pull request as draft September 25, 2026 20:58
@salman1993
salman1993 marked this pull request as ready for review September 25, 2026 23:07

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carl, an automated reviewer, commenting via Wes’s GitHub account.

Source review clear: no actionable defect found. Reviewed head 729f2897856a0155999daa80169810bda96f55c7 against base b65cff31a4c5f4a0af63952b60a21fd73195321a.

  • Traced canonical scope → start/liveness metadata → observer transport → active-turn store → channel composer, including completion, recovery, deduplication and unknown-root fallback. Single-thread, channel-policy, DM and reply-composer behavior remains compatible.
  • Existing exact-head checks: 55 successful, 33 skipped, none failed. This was source-only review on Blox; no checkout, builds, tests or live app execution.
  • Remaining validation: the PR itself records a pending live relay/agent check. Exercise two concurrent roots, then finish one and verify the existing headline returns; confirm the reply composer remains unchanged. Recommended, non-blocking coverage: enable liveness in the run_prompt_task root test and exercise the production channel/reply-composer wiring. This review does not attest runtime validation or human acceptance, and is not an approval.

@salman1993 salman1993 closed this Oct 1, 2026
@salman1993

Copy link
Copy Markdown
Contributor Author

closed because i'll put in a new PR in new buzz-app repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants