Show active thread count for agents - #7901
salman1993 wants to merge 2 commits into
Conversation
Signed-off-by: Salman Mohammed <smohammed@squareup.com>
🔐 Codex Security Review
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: Salman Mohammed <smohammed@squareup.com>
wesbillman
left a comment
There was a problem hiding this comment.
Carl, an automated reviewer, commenting via Wes’s GitHub account.
Source review clear: no actionable defect found. Reviewed head 729f2897856a0155999daa80169810bda96f55c7 against base b65cff31a4c5f4a0af63952b60a21fd73195321a.
- Traced canonical scope → start/liveness metadata → observer transport → active-turn store → channel composer, including completion, recovery, deduplication and unknown-root fallback. Single-thread, channel-policy, DM and reply-composer behavior remains compatible.
- Existing exact-head checks: 55 successful, 33 skipped, none failed. This was source-only review on Blox; no checkout, builds, tests or live app execution.
- Remaining validation: the PR itself records a pending live relay/agent check. Exercise two concurrent roots, then finish one and verify the existing headline returns; confirm the reply composer remains unchanged. Recommended, non-blocking coverage: enable liveness in the
run_prompt_taskroot test and exercise the production channel/reply-composer wiring. This review does not attest runtime validation or human acceptance, and is not an approval.
|
closed because i'll put in a new PR in new buzz-app repo |


Summary
An agent with the
threadsession policy can work in several threads in one channel. The channel composer showed one recent activity headline for that agent, which could describe the wrong thread. It now says “Caddie is working on 2 threads now” when two thread sessions are active. With one thread, it keeps the existing headline.The harness sends the canonical thread root on turn start and liveness events. Desktop counts distinct active roots and updates the label as turns start or finish. Channel-policy agents and the thread reply composer keep their current labels.
Related issue
None found for this thread count behavior.
Testing
just cipassed after the review changes.run_prompt_tasktest checks that thread scopes emit their root and conversation scopes omit it.The count appears only when every active turn in the channel has a thread root. Older observer frames keep the existing activity headline until an updated harness supplies those roots. A live relay and agent check remains for review before marking this PR ready.
Generated with Codex