Skip to content

Remove <Match>#67

Merged
Ayc0 merged 3 commits into
mainfrom
Ayc0/kill-match
Dec 9, 2024
Merged

Remove <Match>#67
Ayc0 merged 3 commits into
mainfrom
Ayc0/kill-match

Conversation

@Ayc0

@Ayc0 Ayc0 commented Oct 2, 2023

Copy link
Copy Markdown
Collaborator

Match is using 2 anti patterns:

  • reading the props of children
  • injecting props to children

Those make it harder to type things properly:

  • for regular HTML components, it relied on a declare module, which was leaking in other people's codebases:
    image
  • for components, it requires to add those props to the API of the components, which makes it harder ot use them (and also is wrong)

So let's remove the <Match> component fully

@Ayc0 Ayc0 merged commit ffe462d into main Dec 9, 2024
@Ayc0 Ayc0 deleted the Ayc0/kill-match branch December 9, 2024 18:39
@Ayc0 Ayc0 changed the title Remove <Match> Remove <Match> Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant