Using exit(1) instead of ::abort on Windows

[wyldckat]

Search for more occurrences of the issue that Symscape has detected on the v3 patch for 2.1.x, where they are using exit(1) instead of ::abort on Windows.

Reference files: src/OpenFOAM/db/error/IOerror.C and src/OpenFOAM/db/error/error.C

[wyldckat]

More specifically, from Symscape's v9 patch file, this is the particular change of interest:

Index: src/OpenFOAM/db/error/IOerror.C
===================================================================
--- src/OpenFOAM/db/error/IOerror.C	(.../tags/2.1.x-6)	(revision 786)
+++ src/OpenFOAM/db/error/IOerror.C	(.../branches/2.1.x-6)	(revision 786)
@@ -247,7 +247,13 @@
             Perr<< endl << *this << endl
                 << "\nFOAM aborting\n" << endl;
             printStack(Perr);
+
+	    // Prefer ::exit(1) to avoid unnecessary warnings on Windows
+#ifdef MSWIN
+	    ::exit(1);
+#else
             ::abort();
+#endif
         }
     }
 }
Index: src/OpenFOAM/db/error/error.C
===================================================================
--- src/OpenFOAM/db/error/error.C	(.../tags/2.1.x-6)	(revision 786)
+++ src/OpenFOAM/db/error/error.C	(.../branches/2.1.x-6)	(revision 786)
@@ -246,7 +246,12 @@
             Perr<< endl << *this << endl
                 << "\nFOAM aborting\n" << endl;
             printStack(Perr);
+	    // Prefer ::exit(1) to avoid unnecessary warnings on Windows
+#ifdef MSWIN
+	    ::exit(1);
+#else
             ::abort();
+#endif
         }
     }
 }

[wyldckat]

Will postponed this task until it's clear in what scenarios it is preferable to use ::exit(1) instead of ::abort().

It does look like that this is related to either resulting in Windows issuing an application memory dump and subsequent reporting option for figuring out a possible fix for why it aborted. More specifically, applications for the Windows Store cannot call ::abort(), with exception during internal development.

However, I want to first be perfectly aware of when this specifically happens when using OpenFOAM in a normal way.