[pull] dev from CyberDrain:dev - #44
Merged
Merged
Conversation
…nt of Check extension
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Brian Simpson <50429915+bmsimp@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Brian Simpson <50429915+bmsimp@users.noreply.github.com>
…main-deployment.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Brian Simpson <50429915+bmsimp@users.noreply.github.com>
…main-deployment.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Brian Simpson <50429915+bmsimp@users.noreply.github.com>
…main-deployment.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Brian Simpson <50429915+bmsimp@users.noreply.github.com>
…une Step 2 - Setup script: mirror the Format-ArrayLiteral change for scalar replacements by adding Format-SingleQuoted and switching all string-valued scalar replacements to single-quoted output. Prevents \$ / backtick interpolation in user-provided URLs and branding fields when generated scripts run. - Docs: add the missing "Step 2: Create the Win32 App in Intune" between packaging and configuration, fixing the 1 -> 3 jump.
Deploy script previously only wrote the toolbar property when $forceToolbarPin = 1. Flipping the setting from 1 to 0 left a stale toolbar_pin=force_pinned / toolbar_state=force_shown on devices, which Detect couldn't reliably catch without causing an infinite redeploy loop. Deploy: always write the toolbar property -- pinned values when =1, default_unpinned / hidden when =0. Matches the CIPP Intune standard. Detect: add ToolbarPinnedValue / ToolbarUnpinnedValue to the $browsers array and always verify the toolbar property against the expected value based on $forceToolbarPin. Addresses Copilot review comment on toolbar pin drift.
Setup: Apply-Replacements now tracks which patterns were found and throws a detailed error listing any missing patterns. Previously a silent miss (e.g., upstream comment reworded) would produce an output script stuck on defaults. Callers now pass -TemplateName so the error identifies which template failed. Detect: convert all remaining bare Test-RegValue calls and bare exit 1 paths to use Test-RegValueWithDetails / Write-DetectionFailure so every failure mode emits a specific reason on stdout. Affects customBranding, genericWebhook, genericWebhook/events (incl. count mismatch and "unexpected events" branches), urlAllowlist (same), and ExtensionSettings. Admins running the script manually now see exactly which check failed. Addresses Copilot review comments on silent replacement failures and missing diagnostic output.
feat: Add Intune detection and setup scripts for Windows deployment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )