Skip to content

Allow command selection in CL command entry - #16

Merged
bobcozzi merged 1 commit into
bobcozzi:mainfrom
sebjulliand:suggestCommands
Sep 13, 2026
Merged

bobcozzi merged 1 commit into
bobcozzi:mainfrom
sebjulliand:suggestCommands

Conversation

@sebjulliand

Copy link
Copy Markdown
Contributor

This PR adds command selection in the Command Entry view.
It allows to search for a command the same way it's done in 5250: type the beginning of a command name + * and press enter.

It will open a QuickPick menu listing all the commands found in the library list or in the command's library if the command name was qualified.

Screen.Recording.2026-09-10.at.15.39.27.mov

All in all, it's very similar to how it works in 5250 😄

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@bobcozzi

Copy link
Copy Markdown
Owner

Oh my. What a great idea

@bobcozzi

Copy link
Copy Markdown
Owner

You revealed something in your PR, library list resolution is connection-config-based and so if CL Prompter is using its own job, then the currentLIbrary and libraryList of getConfig() will be wrong. I will be corrected that in follow-up PR, which I will merge before yours #16, and then offer up changes to yours that use the CLPrompter/CmdEntry jobManager interface.

@bobcozzi
bobcozzi merged commit e996e17 into bobcozzi:main Sep 13, 2026
@sebjulliand

Copy link
Copy Markdown
Contributor Author

Thanks @bobcozzi !
So you merged it before after all?

@bobcozzi

Copy link
Copy Markdown
Owner

What i did was move your's to a new PR 17 and merge it because I had to modify your use of connection.getConfig so it would use the library list from the correct job since we can be using a distinct job. So I implemented that in PR17 and combined it with your stuff, then merged PR17. I know. this git stuff is all greek to me still--but I'm working on it.
Thanks again for the PR, awesome idea.

@sebjulliand
sebjulliand deleted the suggestCommands branch September 13, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants