feat: paste guide text into ModSync with draft instructions#171
Open
bodencrouch wants to merge 25 commits into
Open
feat: paste guide text into ModSync with draft instructions#171bodencrouch wants to merge 25 commits into
bodencrouch wants to merge 25 commits into
Conversation
added 25 commits
June 13, 2026 07:48
Add a configured-only gate across the shared validation pipeline, CLI/GUI install paths, and wizard install start so dismissed, warned, or skipped post-download states cannot proceed without completing the FOMOD wizard.
…mod dir Wire InstallSingleComponentAsync and fail closed when the mod directory is absent; harden duplicate-Guid expansion and agent-facing recovery hints.
Distinguish enumerate failure from non-FOMOD so probe-miss cannot bypass the configured-only validate/install gate (R22).
Anchor ModSync's problem/approach/tracks and document the paste-ingestion slice against current markdown import/export reality.
Add clipboard import via content sniffing, wire NaturalLanguageInstructionParser through DraftInstructionService with path sandboxing, and CLI --stdin/--parse-directions.
Validation log and main output panel use GridSplitters; Welcome and Landing pages reduce whitespace and keep ScrollViewer so content fits compact wizard hosts.
Wire GuiSmokeHeadlessTests plus agent docs so paste-import and compact layout checks run without a desktop session via run_headless_tests.sh.
…artPage Cover pipeline pass/fail, InstallationService block when unconfigured, and headless InstallStartPage ValidateAsync for configured vs unconfigured FOMOD.
Replace MaxHeight-capped notice/review panels with star-row ScrollViewers, wrap explain/finish/install pages for compact hosts, and extend GuiSmoke headless layout coverage.
DateTimeStyles.None turned ISO-8601 Z timestamps into local Kind (-05:00), breaking SerializationRoundTripTests JSON equality. Serialize/parse as UTC and leave FirstSeen unset during ModLink migration (cache owns that field).
IsSandboxedPath now mirrors FOMOD relative-path rules (.., drives, rooted segments) and drafts apply ReviewFlagMessage for GUI install review parity.
Cover wizard Welcome→Validate key controls, LoadInstructionTextAsync sample markdown without a real clipboard, and compact-host ScrollViewer layout; strip WelcomePage inline fonts and wrap badge text to avoid clipping. Document the expanded Headless|GuiSmoke filter in run_headless_tests.sh.
Re-prompt dismissed FOMOD archives on Fetch Downloads, merge Mod Management wizard output into the selected mod, match nested registry basenames for prompt status, and normalize backslash paths when replacing prior FOMOD instructions.
…ning managed-deploy work Progress totals no longer inflate when environment/archive stages are skipped. Refresh validation-pipeline KB for FomodConfiguration fail-closed, add stage UI coverage tests, and capture Phase 4 remaining units in plan 004.
Align STRATEGY/product-vision wording with the release-gap inventory; kept off the FOMOD gate PR.
Mark FOMOD discovery/CLI prompts and guide-paste requirements complete with Implemented code pointers; flesh modsync:// Phase 2 requirements and add multi-author publish/share plan stub aligned with STRATEGY and product vision.
Align fomod-support wording with completed Plan 123 and note residual deferred polish.
Document convert --stdin/--parse-directions and refresh action-parity for shipped guide ingest and CLI FOMOD configure. Surface FomodConfigurationGate recovery hints on warn-continue/skip/missing-choices fail-open paths.
Align P0-5 honesty docs with implemented clipboard/stdin draft ingest and CLI --fomod-choices / MODSYNC_FOMOD_CHOICES post-download configure.
Reuse one NL parser per draft pass, share paste size limits / last-loaded helpers, cascade format detection, and drop redundant ToList on CLI draft results.
Strip markdown emphasis and expand delete/range patterns so real guide prose drafts sandboxed instructions; document paste+CLI-only draft generation; add emission and multi-guide GuideIngestionTests.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
GuideIngestionTests+ GuiSmoke / FomodGate headless filters