Conversation
When a parent conversation is cancelled, look up its subagent conversations from the database and cancel any that are actively working. This prevents orphaned subagent loops from continuing to run (and consume resources) after the parent has been stopped. Added cancelSubagents() to Server which queries for child conversations and cancels their active managers. Called from handleCancelConversation before cancelling the parent itself. Added TestCancelParentCancelsSubagents to reproduce the bug: starts a parent that spawns a subagent running a long bash command, cancels the parent, and verifies the subagent also stops. Fixes boldsoftware#170 Co-authored-by: Shelley <shelley@exe.dev>
Contributor
|
I think we've implemented this in the intervening months. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a parent conversation is cancelled, look up its subagent conversations from the database and cancel any that are actively working. This prevents orphaned subagent loops from continuing to run (and consume resources) after the parent has been stopped.
Added cancelSubagents() to Server which queries for child conversations and cancels their active managers. Called from handleCancelConversation before cancelling the parent itself.
Added TestCancelParentCancelsSubagents to reproduce the bug: starts a parent that spawns a subagent running a long bash command, cancels the parent, and verifies the subagent also stops.
Fixes #170