Reduce the number of MSVC level 4 warnings - #5
Merged
ericniebler merged 1 commit intoDec 4, 2017
Conversation
Contributor
Author
|
@ericniebler Could you please take a look at this PR? |
Contributor
Author
|
@ericniebler Ping. |
Member
|
@ericniebler @sergiud The PR looks okay to me. I'll merge this in one week unless somebody reacts. |
Member
|
Merged. Apologies for being unresponsive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several double to float type conversion warnings issued by MSVC.