fix #157: detect vs2017 (vc141) and setup environment by refack · Pull Request #170 · boostorg/build

refack · 2017-02-28T01:25:53Z

Based on JIT compilation of a C# file and COM

KindDragon · 2017-03-04T02:20:09Z

@@ -907,7 +925,7 @@ local rule configure-really ( version ? : options * )
            # version from the path.
            # FIXME: We currently detect both Microsoft Visual Studio 9.0 and
            # 9.0express as 9.0 here.
-            if [ MATCH "(Microsoft Visual Studio 15)" : $(command) ]
+            if [ MATCH "(14.10)" : $(command) ]


This line should be if [ MATCH "(Microsoft Visual Studio[\/\\]2017)" : $(command) ], because they checking here path to Visual Studio

I know but with 2017 that string is not a part of the path. Only predictable string is 14.10

On my machine it's C:\bin\dev\VS\2017\BuildTools\VC\Tools\MSVC\14.10.24930\bin\HostX64\x64

I think this codepath only for default path to VS, check expression for VS2015 below for example

It's logic to deduce the VS version from a given path. 14.10 is the only stable path part (MSVC\14.10 at most).
There are other patterns in this block RE: line 965
VS2017 setup has been reworked extensively...

KindDragon · 2017-03-04T02:24:17Z

Maybe transfer functionality for debugging in a separate PR to speed up the merger of this PR?

refack · 2017-03-04T17:28:11Z

@KindDragon what debugging functionality specifically?

KindDragon · 2017-03-05T01:10:16Z

Ahh, your PR based on changes from 'debug' branch. I think you should remove this commits from your PR

refack · 2017-03-05T17:43:06Z

Branch base oops (debug and develop look too much alike for a dysxelic ;)

grafikrobot · 2017-03-05T17:48:38Z

General question.. From the other pulls/issues/emails.. Shouldn't the version number be "14.10" or "1410", i.e. not 15.0, nor 14.1, nor 141?

refack · 2017-03-05T17:49:33Z

👍 14.10

refack · 2017-03-05T17:51:32Z

@grafikrobot actually it has nuance, The "whole" Visual Studio suite will be version 15.0, but the C++ toolset will be 14.10

grafikrobot · 2017-03-05T17:55:34Z

@refack I wouldn't call that a nuance.. More like a total clusterf_ck on the part of Microsoft.

refack · 2017-03-05T17:58:17Z

For this project 15.0 is used only as an internal moniker, so can consider it a nuance.... 🤷
RE: dotnet/core#509

KindDragon · 2017-03-06T03:00:28Z

@refack Discussion about 14.10 in PR #167

grafikrobot · 2017-03-08T00:22:31Z

@@ -0,0 +1,272 @@
+// powershell -ExecutionPolicy Unrestricted -Version "2.0" -Command "&{ Add-Type -Path Program.cs; [VisualStudioConfiguration.Program]::Main(@())}"


This needs a license / copyright statement to be considered for inclusion in Boost.

grafikrobot · 2017-03-10T12:44:09Z

After installing VS2017 community I did:

C:\>cd DevRoots\Boost\build-refack\src\tools\vc141helper

C:\DevRoots\Boost\build-refack\src\tools\vc141helper>cl141_path.cmd
"COM Ok"

C:\DevRoots\Boost\build-refack\src\tools\vc141helper>

And as you can see it did not detect my install. Which is installed at the default location.

refack · 2017-03-10T13:34:26Z

@grafikrobot checking

refack · 2017-03-10T13:47:59Z

@grafikrobot can you gist the output of try_powershell.cmd just to make sure you have the VCTools "workload" installed.
Here's mine

grafikrobot · 2017-03-10T14:03:26Z

@refack Sure.. I posted it as a comment on your gist.

refack · 2017-03-10T19:13:07Z

@grafikrobot I tried to simplify the non C# part, and added some fallbacks.

refack · 2017-03-11T00:21:24Z

CI machine passes

jhunold · 2017-03-11T08:53:48Z

Tested the last version of the patch with 2017 Enterprise. Works

refack · 2017-03-12T14:18:45Z

One small step for me, kinda small step for Boost.build 🐱‍🚀
@grafikrobot much respect! 🥇

AndrewPardoe · 2017-04-20T22:41:26Z

The officially supported vswhere tool is now available as part of the install starting today with Visual Studio 15.2 preview 2: https://blogs.msdn.microsoft.com/heaths/2017/04/21/vswhere-is-now-installed-with-visual-studio-2017/. This doesn't fix all the existing installs of VS 2017 but going forward you can now detect the VS install locations and whether C++ tools are available from a scripted environment. I hope this helps your scenario.

refack force-pushed the develop branch 2 times, most recently from 308a246 to dd7a0ef Compare March 3, 2017 17:05

refack mentioned this pull request Mar 3, 2017

Support VS2017 #157

Closed

KindDragon reviewed Mar 4, 2017

View reviewed changes

refack force-pushed the develop branch from 4973c19 to 2877267 Compare March 5, 2017 17:41

refack mentioned this pull request Mar 6, 2017

Fix toolset version for VS2017 (should be 14.1) #167

Closed

refack force-pushed the develop branch from 2877267 to 49eacd8 Compare March 7, 2017 13:24

grafikrobot reviewed Mar 8, 2017

View reviewed changes

refack force-pushed the develop branch 2 times, most recently from 61ea2ce to ed4f151 Compare March 10, 2017 13:41

refack force-pushed the develop branch from ed4f151 to c0217bd Compare March 10, 2017 19:11

refack force-pushed the develop branch from c0217bd to 08ead8f Compare March 10, 2017 23:04

fix bfgroup#157: detect vs2017 (vc141) and setup environment

b2260a9

refack force-pushed the develop branch from 08ead8f to b2260a9 Compare March 10, 2017 23:48

grafikrobot merged commit 747287c into boostorg:develop Mar 12, 2017

refack mentioned this pull request Mar 14, 2017

win: enable build with vs2017 nodejs/node#11852

Closed

3 tasks

KindDragon referenced this pull request in boostorg/config Mar 17, 2017

Fix library name for VC14.1 (Visual Studio 2017)

d5c2dba

github-actions Bot added the transition Transition to bfgroup/b2 label Oct 2, 2021

github-actions Bot locked and limited conversation to collaborators Oct 2, 2021

		@@ -0,0 +1,272 @@
		// powershell -ExecutionPolicy Unrestricted -Version "2.0" -Command "&{ Add-Type -Path Program.cs; [VisualStudioConfiguration.Program]::Main(@())}"

Uh oh!

Conversation

refack commented Feb 28, 2017

Uh oh!

KindDragon Mar 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

refack Mar 4, 2017

Choose a reason for hiding this comment

Uh oh!

refack Mar 4, 2017

Choose a reason for hiding this comment

Uh oh!

KindDragon Mar 5, 2017

Choose a reason for hiding this comment

Uh oh!

refack Mar 5, 2017

Choose a reason for hiding this comment

Uh oh!

KindDragon commented Mar 4, 2017

Uh oh!

refack commented Mar 4, 2017

Uh oh!

KindDragon commented Mar 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

refack commented Mar 5, 2017

Uh oh!

grafikrobot commented Mar 5, 2017

Uh oh!

refack commented Mar 5, 2017

Uh oh!

refack commented Mar 5, 2017

Uh oh!

grafikrobot commented Mar 5, 2017

Uh oh!

refack commented Mar 5, 2017

Uh oh!

KindDragon commented Mar 6, 2017

Uh oh!

grafikrobot Mar 8, 2017

Choose a reason for hiding this comment

Uh oh!

refack Mar 8, 2017

Choose a reason for hiding this comment

Uh oh!

grafikrobot commented Mar 10, 2017

Uh oh!

refack commented Mar 10, 2017

Uh oh!

refack commented Mar 10, 2017

Uh oh!

grafikrobot commented Mar 10, 2017

Uh oh!

refack commented Mar 10, 2017

Uh oh!

refack commented Mar 11, 2017

Uh oh!

jhunold commented Mar 11, 2017

Uh oh!

refack commented Mar 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndrewPardoe commented Apr 20, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

KindDragon Mar 4, 2017 •

edited

Loading

KindDragon commented Mar 5, 2017 •

edited

Loading

refack commented Mar 12, 2017 •

edited

Loading