Skip to content

Replace deprecated runners in CI - #1254

Merged
jzmaddock merged 6 commits into
developfrom
ci_dep
Apr 12, 2025
Merged

Replace deprecated runners in CI#1254
jzmaddock merged 6 commits into
developfrom
ci_dep

Conversation

@mborland

@mborland mborland commented Apr 8, 2025

Copy link
Copy Markdown
Member

No description provided.

@mborland

mborland commented Apr 8, 2025

Copy link
Copy Markdown
Member Author

I'm not quite sure why we have a bloodbath from Boost.Exception now. The file that's popping up as an error hasn't been modified in over 2 years.

@jzmaddock

Copy link
Copy Markdown
Collaborator

We must have a test that has off and is - possibly indirectly - pulling in Boost.Exception. I don't see it at present though.

@mborland

Copy link
Copy Markdown
Member Author

I think it's coming up as a secondary dependency from Boost.Container since the failure looks like:

gcc.compile.c++ ../../../bin.v2/libs/container/build/gcc-14/debug/x86_64/exception-handling-off/link-static/threading-multi/visibility-hidden/pool_resource.o
gcc.compile.c++ ../../../bin.v2/libs/system/build/gcc-14/debug/x86_64/exception-handling-off/link-static/threading-multi/visibility-hidden/error_code.o
gcc.archive ../../../bin.v2/libs/container/build/gcc-14/debug/x86_64/exception-handling-off/link-static/threading-multi/visibility-hidden/libboost_container.a
gcc.archive ../../../bin.v2/libs/system/build/gcc-14/debug/x86_64/exception-handling-off/link-static/threading-multi/visibility-hidden/libboost_system.a
gcc.compile.c++ ../../../bin.v2/libs/exception/build/gcc-14/debug/x86_64/exception-handling-off/link-static/threading-multi/visibility-hidden/clone_current_exception_non_intrusive.o
In file included from ../../../libs/exception/src/clone_current_exception_non_intrusive.cpp:14:
../../../boost/exception/detail/clone_current_exception.hpp:22:6: error: #error This header requires exception handling to be enabled.
   22 | #    error This header requires exception handling to be enabled.
      |      ^~~~~

    "g++-14"   -fvisibility-inlines-hidden -fno-exceptions -std=c++20 -m64 -pthread -O0 -fno-inline -Wall -g -fvisibility=hidden  -DBOOST_ALL_NO_LIB=1 -DBOOST_MATH_RUN_MP_TESTS -DCI_SUPPRESS_KNOWN_ISSUES -DSLOW_COMPILER   -I"../../.."  -c -o "../../../bin.v2/libs/exception/build/gcc-14/debug/x86_64/exception-handling-off/link-static/threading-multi/visibility-hidden/clone_current_exception_non_intrusive.o" "../../../libs/exception/src/clone_current_exception_non_intrusive.cpp"

test_instantiate has some very old dependencies in it so maybe breaking those would help?

@jzmaddock

Copy link
Copy Markdown
Collaborator

test_instantiate is a compile-only test, it shouldn't be building any dependencies IMO.

@mborland

mborland commented Apr 10, 2025

Copy link
Copy Markdown
Member Author

test_instantiate is a compile-only test, it shouldn't be building any dependencies IMO.

Should this be changed to compile then?

[ run test_instantiate1.cpp test_instantiate2.cpp  : : : <exception-handling>off : test_instantiate_no_eh ]

In the no-exception handling runs everything fails so that only kind of helps?

Edit: Locally this works fine [ compile test_instantiate1.cpp test_instantiate2.cpp : <exception-handling>off : test_instantiate_no_eh ]

@jzmaddock

Copy link
Copy Markdown
Collaborator

You're correct: the build log clearly shows that test_instantiate is the culprit, BUT it passes locally for me, and the Jamfile clearly shows no dependencies at all for that target, and certainly no mention of Boost.Exception being required. For that matter Boost.Exception (the library) is absolutely NOT a dependency, only the stub header. So I'm confused right now.

@jzmaddock

Copy link
Copy Markdown
Collaborator

Reproduced locally.

@jzmaddock

Copy link
Copy Markdown
Collaborator

The dependency is introduced by Boost.Test which isn't used by that target, I nearly have a fix that I'm testing locally...

@codecov

codecov Bot commented Apr 12, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.83%. Comparing base (a5c0625) to head (5a41763).
Report is 13 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1254   +/-   ##
========================================
  Coverage    93.83%   93.83%           
========================================
  Files          657      657           
  Lines        55244    55244           
========================================
  Hits         51840    51840           
  Misses        3404     3404           
Files with missing lines Coverage Δ
include/boost/math/tools/big_constant.hpp 100.00% <ø> (ø)
include/boost/math/tools/test_value.hpp 100.00% <ø> (ø)
test/test_hermite.hpp 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5c0625...5a41763. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jzmaddock

Copy link
Copy Markdown
Collaborator

OK this looks good to go, only failures are from cycl Cauchy tests.

I'll let @mborland look at those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants