boost 88 process.hpp broke v1 compatibility

[fsmoke]

boost 88 process.hpp broke v1 compatibility, now there is no common header for v1 - we ware enforced to fix dozens of projects !!

As far as i know there is no groups support in v2 for now - why compat was broken? without any alternatives...

[klemens-morgenstern]

I can add a process/v1.hpp header for 1.89 if that's all you need. If you #define BOOST_PROCESS_VERSION 1 the API would be the same.

What's your use-case for process groups? I did not add them to v2 because they are too different between posix & windows.

[fsmoke]

I can add a process/v1.hpp header for 1.89 if that's all you need

Yes this whould be nice

we have some kind of shell launcher which run multiple child process - theese children run subchild processes and so on. But when we close/kill shell(or it crashes) - all subprocesses and subsubprocesses must be guaranteed closed

in other words we use groups to automatic kill all (child)processes in group

[klemens-morgenstern]

Are you running windows & posix or just one?

[fsmoke]

Yes, we have cross platform product for windows and couple of linux distros

[Nelson-numerical-software]

Will v1 compatibility continue to be maintained or will we start migrating to v2?

[nega0]

If this bit you too, and you got something like

$ make |& grep error: |& cut -d: -f4-
 error: no type named 'child' in namespace 'boost::process'
 error: no type named 'opstream' in namespace 'boost::process'
 error: no member named 'std_in' in namespace 'boost::process'
 error: no member named 'std_out' in namespace 'boost::process'
 error: no member named 'null' in namespace 'boost::process'
 error: no member named 'std_err' in namespace 'boost::process'
 error: no member named 'start_dir' in namespace 'boost::process'
 error: no member named 'child' in namespace 'boost::process'

You now want something like

@@ -1,2 +1,11 @@
+#include <boost/version.hpp>
+#if BOOST_VERSION < 108800
 #include <boost/process.hpp>
 namespace process = boost::process;
+#else
+#include <boost/process/v1/child.hpp>
+#include <boost/process/v1/io.hpp>
+#include <boost/process/v1/pipe.hpp>
+#include <boost/process/v1/start_dir.hpp>
+namespace process = boost::process::v1;
+#endif

[klemens-morgenstern]

You can also define BOOST_PROCESS_VERSION 1 so all the v1 symbols are in boost::process and not boost::process::v1.

[jakobandersen]

I was hit by the changes in 1.88 as well, in that I didn't even know v2 existed. Is there a changelog somewhere of what happened in each release? The overall Boost release notes have no entries for Process that I could find in multiple releases.

[Nelson-numerical-software]

Will compatibility with version 1 continue to be maintained in future releases, or migration to version 2 is required ?

[klemens-morgenstern]

There is documentation of the v2 IF here: https://www.boost.org/doc/libs/1_88_0/libs/process/doc/html/index.html#version_2
The v2 was added several versions ago, I think in 1.81. I sadly have to admit that I am bad at release notes.

I will keep the v1 sources around as is and may accept PRs. The v1 interface has major problems, so I had to introduce a breaking change at some point. I would strongly encourage migration.

[nigels-com]

We did a migration to "get with the program" and modernise some surrounding mess of our own making.
It was the main blocker for moving to boost 1.88.0 and it does seem like we're safely on the other side now.
One positive thing for us is that it aligns better with boost::asio, which we also have in the mix.

[toonetown]

Is there some kind of migration guide to move from v1 to v2? For example, I cannot find anywhere where the v2 equivalent of boost::process::v1::spawn would be.

[klemens-morgenstern]

You can find a summary here: https://www.boost.io/doc/libs/latest/doc/html/process.html#version_2

spawn(...) would be process(...).detach().