jepsen: avoid S3 checker timeouts - #1181
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughS3 レジスタ用チェッカーを関数化し、線形化可能性チェッカーの明示的な ChangesS3 Jepsen 更新
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR changes only the S3 analysis strategy while preserving workload behavior and adds regression coverage; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Root cause
Scheduled Jepsen run #563 completed the S3 workload but timed out during analysis with exit code 124. The S3 checker forced Knossos's linear analyzer, whose search space can grow pathologically when a history contains indeterminate writes. The run did not report a linearizability violation before the timeout.
Using Knossos's default competition checker preserves the verdict while returning as soon as either the linear or WGL analyzer finishes.
Impact
The S3 workload parameters and register model are unchanged. Only the analyzer selection changes. Future S3 failures will also retain the Jepsen store artifact for diagnosis.
Validation
cd jepsen && lein test— 148 tests, 340 assertionsactionlint -ignore SC2034 .github/workflows/jepsen-test-scheduled.ymlgit diff --checkSummary by CodeRabbit
テスト
改善