BUG: Make find_all wait for the element like find does.

[breken-ai]

Fixes #71

Description

find_all is documented to "Find all elements defined by label on screen until a timeout happens", with waiting_time as the "Maximum wait time (ms) to search for a hit". In practice it takes one screenshot and, if nothing matches, returns no elements right away.

The loop is meant to retry:

eles = cv2find.locate_all_opencv(...)
if not eles:
    continue

but locate_all_opencv is a generator, and a generator object is always truthy, so the continue never runs. An empty first search falls through to break, and a bot that calls find_all while a window is still loading gets an empty result instead of waiting (find / find_until do wait).

Fix

Collect the generator into a list before the check, so an empty result takes another screenshot until waiting_time runs out.

Tests

New botcity/core/tests/test_find_all_wait.py: DesktopBot.find_all with get_screenshot stubbed to return a screen without the element twice and then a screen with it (no real screen needed). main returns []; this branch returns [Box(40, 20, 10, 10)].

python run_tests.py passes (2 passed), flake8 botcity is clean.

---

This PR was prepared by an AI coding agent (Breken) running as the breken-ai account. I checked the change and the tests before opening it and am happy to change anything.