Skip to content

chore: Clean up no longer used method sourcePathsFor() on Psr4SourcePathsRule #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 1 commit into from
Aug 27, 2026
Merged

chore: Clean up no longer used method sourcePathsFor() on Psr4SourcePathsRule #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/Rule/Rules/Composer/Psr4SourcePathsRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,6 @@ public function __construct(
) {
}

/**
* @return list<string>
*/
public function sourcePathsFor(string $basePath): array
{
if ($this->sourcePaths === null) {
return $this->psr4PathResolver->paths($basePath);
}

return $this->normalisePaths($this->sourcePaths, $basePath);
}

public function evaluateProject(string $basePath, Architecture $architecture, array $skipPaths = []): ?RuleViolation
{
$composerFile = rtrim($basePath, '/') . '/composer.json';
Expand Down
10 changes: 0 additions & 10 deletions tests/Rule/Composer/Psr4SourcePathsRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,14 +157,6 @@ public function testReadsSourcePathsFromComposerWhenSourcePathsAreNotConfigured(
RuleViolation::class,
$psr4SourcePathsRule->evaluateProject($basePath, Architecture::define())
);
$this->assertSame(['app', 'tests', 'specs'], $psr4SourcePathsRule->sourcePathsFor($basePath));
}

public function testNormalisesExplicitSourcePaths(): void
{
$psr4SourcePathsRule = new Psr4SourcePathsRule([' src/ ', 'tests\\']);

$this->assertSame(['src', 'tests'], $psr4SourcePathsRule->sourcePathsFor($this->makeTempDir()));
}

public function testPassesWhenDotRelativeSourcePathsExistInComposerPsr4Autoloads(): void
Expand All @@ -190,7 +182,6 @@ public function testPassesWhenDotRelativeSourcePathsExistInComposerPsr4Autoloads
RuleViolation::class,
$psr4SourcePathsRule->evaluateProject($basePath, Architecture::define())
);
$this->assertSame(['src', 'tests'], $psr4SourcePathsRule->sourcePathsFor($basePath));
}

public function testPassesWhenAbsoluteSourcePathsExistInComposerPsr4Autoloads(): void
Expand All @@ -216,7 +207,6 @@ public function testPassesWhenAbsoluteSourcePathsExistInComposerPsr4Autoloads():
RuleViolation::class,
$psr4SourcePathsRule->evaluateProject($basePath, Architecture::define())
);
$this->assertSame(['src', 'tests'], $psr4SourcePathsRule->sourcePathsFor($basePath));
}

public function testPassesWhenComposerUsesAbsoluteSourcePath(): void
Expand Down
Loading