Skip to content

perf: Avoid redundant deduplication of paths already deduplicated by Psr4PathResolver::normalisePaths(). #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 1 commit into from
Aug 31, 2026
Merged

perf: Avoid redundant deduplication of paths already deduplicated by Psr4PathResolver::normalisePaths(). #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Rule/Rules/File/PhpFileFinder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,10 @@ public function filesFromScope(
/** @return list<string> */
private function sourcePaths(string $basePath): array
{
return array_values(array_unique($this->sourcePaths ?? $this->psr4PathResolver->paths($basePath)));
if ($this->sourcePaths === null) {
return $this->psr4PathResolver->paths($basePath);
}

return array_values(array_unique($this->sourcePaths));
}
}
Loading