Add AM/PM style option for clock overlay - #7
Conversation
- Added useAmPm to ConfigProvider and implemented it in JsonConfigService. - Added use_am_pm setting to assets/config.json. - Added localization strings for useAmPm in English and German. - Updated SettingsScreen to include a switch for AM/PM format under Clock settings. - Updated ClockOverlay to format time in 12-hour format when useAmPm is true. - Updated SlideshowScreen to pass the useAmPm setting to ClockOverlay. - Fixed missing concrete implementations of useAmPm in test mocks. Co-authored-by: brad <1614+brad@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR adds a new setting to allow users to display the clock in 12-hour format with AM/PM indicators. It includes updates to the configuration provider, localization files, settings screen, and the clock overlay widget itself. Tests have been updated to reflect the changes in the configuration interface.
PR created automatically by Jules for task 8660465772071478575 started by @brad