Skip to content

test block with no tests, and test counts #483

Description

@shriram

I feel like we've been over this before, but I can't find the PR right now…

It seems really confusing to use a green background for "no tests" blocks. Students see

image

and don't read the fine-print and think a bunch of top-level function calls (with no testing operators) is a valid test suite.

Didn't we discuss changing the color of such blocks? If anything, it should be a "negative" color, because more likely than not this is an error (and if it's intentional, the programmer will know — but even then, they may later forget to change the block to contain tests again, so the reminder can't hurt).

I realize there's a fine line here and green for a single test could still obscure similar errors. We should still handle this special case differently because it would be instructive for students. But perhaps instead of a small number amidst a lot of text

image

we should have a stronger visual indicator of how many tests passed [like this, but even more salient]:

image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions