Skip to content
This repository was archived by the owner on Jun 11, 2024. It is now read-only.
This repository was archived by the owner on Jun 11, 2024. It is now read-only.

Doesn't work as expected with JDK10+ #245

Description

@doublemarket

Describe the bug

When using browserup-proxy with JDK10+, it's not possible to set a custom port when creating a new proxy config. This is because parsing the data in a POST request doesn't work as expected because mvel which is contained in browserup-proxy can't run with JDK10+ with an issue.

To Reproduce

Refer to the issue autifyhq/docker-browserup-proxy#2 as well.

Steps to reproduce the behavior:

  1. Start browserup-proxy with JDK10+ (I tested with JDK14).
  2. Issue a POST request to /proxy with the 'port=8099' data.
    • The result is same when providing the data with JSON ({"port":8099}).
    • Other options as well. I didn't try with every option but trustAllServers can't be set as well.
  3. browserup-proxy returns a 500 error.

Expected behavior

browserup-proxy should return a port number when hitting with the port number.

Screenshots
If applicable, add screenshots to help explain your problem.

Please complete the following information:

  • OS : Ubuntu
  • Browser : curl

Additional context

Providing the version info to mvel by adding a line in the browserup-proxy code is an option.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions