feat(desktop): pin Qlassy to a qlassy-theme release - #60
Merged
Merged
Conversation
Point at the v0.1.0 tag instead of a raw commit SHA now that qlassy-theme cuts releases. Same github-release-url.sh --snapshot path (GitHub serves a source tarball for a tag the same way it does for a commit), but the pin is now a legible, reviewable version instead of an opaque hash. v0.1.0 also carries a fix from qlassy-theme: cursors follow the Qogir icon theme instead of Breeze, and both variants use Plasma's stock Breeze Plasma style instead of Klassy's, which was forcing "Automatic" dynamic wallpapers to their dark variant. Claude-Session: https://claude.ai/code/session_015BvZMmeLfSMELsrvCv36Yr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Point the Qlassy pin in
build_scripts/desktop-kde-themes.shat qlassy-theme'sv0.1.0release tag instead of a raw commit SHA. Samegithub-release-url.sh --snapshotpath — GitHub serves a source tarball for a tag the same way it does for a commit — but the pin is now a legible, reviewable version instead of an opaque hash. sha256 recomputed against that tag's tarball.Why
Discussed in chat: a released tag is a better reference than "latest commit on main" — Renovate can at least surface a new qlassy-theme release via a
github-releases/github-tagsdatasource, even though the sha256 recompute still has to stay a manual, reviewed step (by design — see the pin's purpose below). That Renovate wiring isn't part of this PR; only the pin move.Bonus from the release itself
v0.1.0(one commit past what #58 pinned) carries a qlassy-theme fix: cursors now follow the Qogir icon theme instead of defaulting to Breeze, and both variants use Plasma's stock Breeze Plasma style instead of Klassy's own — Klassy's style was forcing "Automatic" dynamic wallpapers to always pick their dark variant.Validation
shellcheck+shfmt -i 4clean.curl -sL https://github.com/bsherman/qlassy-theme/archive/v0.1.0.tar.gz | sha256summatches the pinned value.just build bazzitenot re-run for this change (no logic changed, only the pin/ref values).https://claude.ai/code/session_015BvZMmeLfSMELsrvCv36Yr