Skip to content

Is passing an invalid pointer to recv sound? #50

Description

@Manishearth

// Detect read shutdown. A normal zero-length `recv` does block, so
// use deliberately invalid pointer, as we get different error codes in
// the case of a shut-down stream.
let read_result = unsafe { recv(socket, usize::MAX as *mut _, 1, MSG_PEEK) };
if read_result == SOCKET_ERROR {
let err = io::Error::last_os_error();
match err.raw_os_error() {
Some(WSAEFAULT) => (),
Some(WSAESHUTDOWN) => read = false,
_ => return Err(err),
}
}

https://learn.microsoft.com/en-us/windows/win32/api/winsock/nf-winsock-recv doesn't say anything about this, this seems sketchy.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions