Conversation
fcortes
marked this pull request as draft
July 6, 2025 02:43
Author
|
Set as draft as after some experimentation I could reliable replicate it with docker. On my machine the gcc version installed is 15.1.1 but GCC releases and repositories only go up to 15.1.0. The patch seems to come from arch but haven't found the source yet. I was trying to test different combinations of GCC and ruby version with this: # Dockerfile
ARG GCC_VERSION=14
ARG RUBY_VERSION=3.4.4
FROM ruby:${RUBY_VERSION} AS ruby-source
FROM gcc:${GCC_VERSION}
COPY --from=ruby-source /usr/local /usr/local
# Update shared library cache
RUN ldconfig
# Install runtime dependencies
RUN apt update && \
apt install -y libssl3 libreadline8 zlib1g libffi8 libyaml-0-2 \
build-essential
WORKDIR /app
COPY . /app
RUN bundle install
CMD ["rake", "compile"]And trying combinations of GCC and ruby versions with docker build \
--build-arg GCC_VERSION=15.1.0 \
--build-arg RUBY_VERSION=3.4.4 \
-t cbor-ruby .
docker run --rm cbor-rubyVersion is |
Contributor
|
#29 is an alternative approach. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27
GCC 15 was released on April and is starting to be rolled into distros package managers. For some reason the extension compilation fails when used with GCC 15 with some type errors (I suspect some import path rule changed as inspecting the files do show the types correctly imported).
It is exactly the same as this bug reported on Fedora 42 and seems to be related to this GCC regresion bug but I'm not 100% sure as they talk about some errors coming up when LTOs are enabled (which I'm not sure whether they are or not enabled). May also be related to this other bug but they report that GCC 15 defaults to C23 and that makes extension builds fail.
Anyways, removing the flag and letting gcc use its default value seems to work fine for GCC14 and GCC15