Skip to content

Adding Int'l Support with Versioned Redirect Templates - #5

Merged
cadamsdotcom merged 5 commits into
cadamsdotcom:masterfrom
maxslabyak:master
Feb 19, 2014
Merged

Adding Int'l Support with Versioned Redirect Templates#5
cadamsdotcom merged 5 commits into
cadamsdotcom:masterfrom
maxslabyak:master

Conversation

@maxslabyak

Copy link
Copy Markdown
Contributor

Changes

  • Constants.cs
    • refactored hardcoded strings into Constants static class
  • Redirects.cs
    • GetRedirects() modified to accept an additional template name - versioned template name.
    • Added an additional lookup for fast query to pull only the active versions from the context language.
    • Documented fast query behavior in the comments of not guaranteeing context-specific results

Suggestions

  • Document the placement of the Redirect assembly in the .config file - before vs. after

@ghost ghost assigned cadamsdotcom Jan 21, 2014
Comment thread source/Redirects.cs Outdated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be Any() instead for more brevity

@maxslabyak

Copy link
Copy Markdown
Contributor Author

cleaned up LINQ for brevity

cadamsdotcom added a commit that referenced this pull request Feb 19, 2014
Adding Int'l Support with Versioned Redirect Templates
@cadamsdotcom
cadamsdotcom merged commit 3e1da8d into cadamsdotcom:master Feb 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants