fix(snackbar): fix show animation on new architecture#4447
Merged
lukewalczak merged 1 commit intoJul 27, 2024
Merged
Conversation
|
Hey @seb-zabielski, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
@seb-zabielski @gedu Is there a tentative timeline for 5.12.4. Also, random question, but is @lukewalczak no longer maintaining this? |
lukewalczak
approved these changes
Jul 27, 2024
momomuchu
added a commit
to momomuchu/react-native-paper
that referenced
this pull request
Jul 5, 2026
…d:false under Fabric, callstack#4951 Under the New Architecture (Fabric), `Animated.timing` can fire its `start` callback with `{ finished: false }` even when the hide animation completes naturally (no interruption). The previous code guarded `setHidden(true)` behind `if (finished)`, so the Snackbar stayed mounted forever on Fabric after `visible` became false. The fix removes the guard and calls `setHidden(true)` unconditionally in the animation callback, mirroring the show-path fix from PR callstack#4447 which addressed the same class of Fabric noise for `handleOnVisible`. The sole trade-off is a mid-hide interrupt: if `visible` flips back to `true` while the hide animation is running, `setHidden(true)` fires, but the subsequent render immediately calls `setHidden(false)` via `handleOnVisible`, causing at most a one-frame visual snap, strictly better than a permanently stuck Snackbar that no state change can clear. Adds a regression test that mocks `Animated.timing` to deliver `{ finished: false }` and asserts the component unmounts cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This bug is only available on android with new architecture enabled and is well described (with and example) in the related issue #4445
From what I've been able to find, the problem occurs when the animation is started before the component is rendered.
In our scenario, the component returns null as long as the
hiddenstate is set to true. In thehandleOnVisiblefunction we have the main stepssetHidden(false)and Animation start. To fix the bug, I moved the start of the animation to a useEffect that depends on thehiddenvalue, so that the animation will start after the state is changed (and component re-rendered).btw, since this bug only occurs with the new architecture, it is either also a react-native bug or an expected change. I have not found an answer yet.
Related issue
#4445
Test plan
Run android app with New Architecture enabled and try to show/hide snackbar.
Screen.Recording.2024-07-01.at.09.47.14.mov
Screen.Recording.2024-07-01.at.09.44.12.mov