Skip to content

feat(scanners): additional findings processor - #7518

Merged
lcampbell2 merged 20 commits into
masterfrom
feat/additional-findings-processor
Sep 18, 2026
Merged

lcampbell2 merged 20 commits into
masterfrom
feat/additional-findings-processor

Conversation

@lcampbell2

Copy link
Copy Markdown
Collaborator

Adds a new scanners/findings-processor Go service that consumes finding events from NATS JetStream and upserts normalized documents into ArangoDB additionalFindings.

  • Introduces a standalone service scaffold (cmd/service, internal/*, go.mod, Dockerfile, Makefile, cloudbuild, env template, README).
  • Implements config/env loading, structured logging, and graceful shutdown.
  • Subscribes to scans.findings.* (configurable), validates event payloads, and applies explicit Ack/Nak/Term handling.
  • Adds finding normalization + deterministic key generation, then upsert logic that creates new docs or updates lastSeen and occurrence count for existing docs.
  • Includes broad unit test coverage across config, model validation/mapping, DB upsert flow, and runner/event behavior.

@lcampbell2
lcampbell2 requested a review from FestiveKyle August 14, 2026 17:05
@lcampbell2

Copy link
Copy Markdown
Collaborator Author

/gcbrun

@lcampbell2

Copy link
Copy Markdown
Collaborator Author

/gcbrun(84c5a2c)

@lcampbell2
lcampbell2 marked this pull request as ready for review August 14, 2026 17:22
Comment thread scanners/findings-processor/internal/database/upsert.go Outdated
Comment thread scanners/findings-processor/internal/database/upsert.go Outdated
Comment thread scanners/findings-processor/internal/model/finding.go
Comment thread scanners/findings-processor/internal/runner/actions.go Outdated
Comment thread scanners/findings-processor/internal/database/upsert_test.go Outdated
Comment thread scanners/findings-processor/internal/database/upsert.go Outdated
Comment thread scanners/findings-processor/README.md Outdated
Comment thread scanners/findings-processor/internal/runner/deps.go Outdated
@lcampbell2
lcampbell2 requested a review from FestiveKyle August 31, 2026 17:51
Comment thread scanners/findings-processor/internal/runner/processor.go Outdated
Comment thread scanners/findings-processor/internal/runner/processor.go Outdated
Comment thread scanners/findings-processor/internal/database/upsert.go
Comment thread scanners/findings-processor/cloudbuild.yaml
@lcampbell2 lcampbell2 changed the title feat: additional findings processor feat(scanners): additional findings processor Sep 16, 2026

@FestiveKyle FestiveKyle left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be all good after these 👍

Comment thread scanners/findings-processor/internal/runner/processor.go Outdated
Comment thread scanners/findings-processor/internal/runner/processor.go Outdated
Comment thread scanners/findings-processor/go.mod Outdated
Comment thread scanners/findings-processor/internal/runner/processor.go Outdated
@lcampbell2
lcampbell2 merged commit 363fab2 into master Sep 18, 2026
40 checks passed
@lcampbell2
lcampbell2 deleted the feat/additional-findings-processor branch September 18, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants