Conversation
Contributor
|
Adding @rgugliel-da & @soren-da to review as they were tagged on the original PR. |
Contributor
Thanks. I asked @thibault-da to review, has he is more knowledgeable than I am. |
Contributor
|
I don't understand why we're not seeing a link to a mintlify preview for this PR (like we did in #971 for instance). I'll ask around. In the meantime @angelol it seems like you need to add Signed-off-by to your commits, see https://github.com/canton-network/cf-docs/pull/1577/checks?check_run_id=101990688191. |
Ported from the reviewed rst page in digital-asset/canton#652, which was held open pending the move to this repo. Placed beside the external-signing deep dives; the Sphinx literalinclude of the config snippet is inlined and the cross-references now point at the corresponding pages here. Signed-off-by: Angelo Laub <angelolaub@gmail.com>
No duplicated H1 after the frontmatter, Title Case headings, the flow as a Steps component, conf fence for the config block, bold for the introduced term, Next Steps as the closing section. Signed-off-by: Angelo Laub <angelolaub@gmail.com>
angelol
force-pushed
the
angelol/external-calls-deep-dive
branch
from
September 11, 2026 07:44
89cd760 to
74b699f
Compare
Author
|
Signed off and repushed — DCO is green now. |
Contributor
|
It generally looks good to me but I have a few comments:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an External Calls page under Deep Dives, next to the External Signing group, and registers it in the navigation.
This is the port of digital-asset/canton#652, which was written and reviewed there but held open once rst files were frozen in favor of this repo (context: digital-asset/canton#644 (comment)). Changes relative to the rst: the Sphinx
literalincludeof the participant config snippet is inlined as a code block, the:ref:cross-references point at the corresponding pages here (external-signing-hashing-algorithm, error-codes), and the early-access warning now names the concrete versions (protocol version 36, LF 2.4).mint broken-linksreports no issues in the new page (the 13 pre-existing findings are in unrelated files).