Fix IssueLoopConfig type errors from bad merge - #4392
Merged
Conversation
The IssueLoopConfig interface was updated to use `createValidator` (a factory function) instead of `validator`, but two call sites were not updated during the merge — causing lint:types failures on main. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lukemelia
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IssueLoopConfiginterface was updated to usecreateValidator(a factory function) in Make ValidationPipeline issue-scoped so TestRun cards correlate to specific issues #4381, but two call sites still referenced the oldvalidatorproperty after a bad merge, breakinglint:typeson main.factory-issue-loop-wiring.tsto pass acreateValidatorfactory function instead of a single validator instance.issue-loop-smoke.tsto usecreateValidator: () => new NoOpValidator().Test plan
validatortype errors no longer appear inpnpm lintoutput🤖 Generated with Claude Code