-
Notifications
You must be signed in to change notification settings - Fork 12
Get file extension and realm info #656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
8185d22
get file extension and realm info
tintinthong bce717f
reinclude test
tintinthong 33bb5eb
put getRealmInfo in resource
tintinthong dd5d140
fix url bug
tintinthong 21defef
cache request
tintinthong f754c0f
lint
tintinthong 69e3ef5
Use adoption manager and use loading states
tintinthong 97d686e
add selection of card
tintinthong 2fb1bc3
mock out some ui
tintinthong 916f4e9
Merge branch 'main' into add-extension-and-realm-info
tintinthong 4a98b73
fix lint
tintinthong 9133227
refactor for better loading pattern and clearer role
tintinthong 6efc1ef
Change selections to a single object
tintinthong a664938
might as well use a select button
tintinthong 7d32901
add comment
tintinthong f8a2140
fix loading
tintinthong a1594a3
place realm info deeper in definition info
tintinthong efb0691
maintain selected card type api
tintinthong d84cecb
Merge branch 'main' into add-extension-and-realm-info
tintinthong 20f00a6
TODO for test
tintinthong d1df438
TODO test
tintinthong edd0e60
wokraround 4 redirect in host test
tintinthong 346767f
Revert "TODO test"
tintinthong cc90d68
Revert "TODO for test"
tintinthong aa1e1fb
fix due to card no longer being resource. TODO: solve .json identific…
tintinthong 60365c7
Merge branch 'main' into add-extension-and-realm-info
tintinthong 466ee51
Fix test using a mock redirected response (#667)
tintinthong e6ef76e
use pathname
tintinthong b6e7f77
Merge branch 'main' into add-extension-and-realm-info
tintinthong 3debe8e
move everything to code mode
tintinthong c9309bd
Fix lint
tintinthong 2c3b147
Fix linting
tintinthong ffb2ace
fix info service to get card source accept header
tintinthong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using the
RealmInfoProvidercomponent (it was merged recently) so you don't have to pass the realm info into this component and you can get rid of therealmIcongetter