fix: type the example.py camera node as Device - #97
Open
forest-savage1234 wants to merge 2 commits into
Open
Conversation
Cites casework#43. Does not close it. The rest of the generic-ObservableObject work stays open. Adds class Device(ObservableObject) next to File (same four lines, @type uco-observable:Device) and changes the named camera constructor only. device_phone_object and the other ObservableObject() calls stay. Out of scope: Mapping-Python casework#50 / casework#18, rewriting every other ObservableObject() in example.py, a class generator, UCO #363, dropping or rewriting Bundle. Identity if committed: Forest Savage <forestsavage03@gmail.com> Do not push from this packet.
Cites casework#43. Does not close it. The rest of the generic-ObservableObject work stays open. Adds class Device(ObservableObject) next to File (same four lines, @type uco-observable:Device) and changes the named camera constructor only. device_phone_object and the other ObservableObject() calls stay. Out of scope: Mapping-Python casework#50 / casework#18, rewriting every other ObservableObject() in example.py, a class generator, UCO #363, dropping or rewriting Bundle. Identity if committed: Forest Savage <forestsavage03@gmail.com> Do not push from this packet.
Author
|
Thank you for the time on this review. This adds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Device for the camera node in example.py
Cites #43 for the named camera line. Does not close it. The rest of the generic-
ObservableObjectwork stays open.Repo rules (casework/CASE-Mapping-Python): no CONTRIBUTING, no PR template. Open against
main. CI is.github/workflows/ci.yml. Boxes match commands actually run on this box afterPATCH.diff.pre-commit run --all-filespoetry run mypy case_mapping example.py testspoetry run pytest --doctest-modulespoetry run python example.pyDo not drop Bundle. Do not reopen UCO #363.
Summary
example.pystill types the Nikon camera as a bareObservableObject. Alex's comment on #43 says that line should beuco.observable.Device().Devicedid not exist on main (onlyDeviceFacet). This addsclass Device(ObservableObject)next toFile— same four lines,@typeuco-observable:Device— and changes that one constructor.Validation
Shallow clone of casework/CASE-Mapping-Python
main@ea0ee6645ba10135e3c4232e79fb8bbb5e34f50c(2026-07-20 5:36am AKDT). Separate apply on a clean worktree/workspace/checkouts/CASE-Mapping-Python-43(branchforest/mappy-43-example-device, not pushed).PATCH.diffapplied (patch -p1).poetry installfrom the lock file, then the four CI commands. Identity for any later commit: Forest Savage forestsavage03@gmail.com. Nothing posted. Ran on Python 3.13.5 / Poetry 2.4.1 (CI matrix is 3.10 and 3.14; those were not on this box).Exit 0.
Exit 0.
Exit 0.
Exit 0. Wrote 80834 bytes to stdout.
Device()["@type"]isuco-observable:Device.example.pyL57 isdevice_camera = uco.observable.Device(). L590device_phone_object = uco.observable.ObservableObject()is unchanged.class Bundleremains atcase_mapping/uco/core.py:65.Files
case_mapping/uco/observable.py(Device, same shape asFile)example.py(device_camera = uco.observable.Device())Out of scope
ContentDataFacetwarn on encounteringimage/jpgforobservable:mimeType? #50 (image/jpg warning)ObservableObject()inexample.py(includingdevice_phone_object)BundleHow to review
Device()["@type"]isuco-observable:Device.git grep -n device_camera example.pyshows one constructor change. The otherObservableObject()calls are unchanged.Volunteer stand-down
I am a volunteer. If you wanted the generator instead of this one node, or if Device should wait until more of example.py is retyped, I will stand down.
I am a volunteer. Thank you for the time. I am trying to become more useful on this work, so I welcome a critical look. If this is the wrong cut, or you want me to stand down, say so and I will recut from notes.
This does not close #43. If Device on that camera line is wrong, I will stand down.