fix: NSRLFile OpSystemCode source is the file, not the OS - #8
Open
forest-savage1234 wants to merge 1 commit into
Open
fix: NSRLFile OpSystemCode source is the file, not the OS#8forest-savage1234 wants to merge 1 commit into
forest-savage1234 wants to merge 1 commit into
Conversation
Signed-off-by: Forest Savage <forestsavage03@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: NSRLFile OpSystemCode source is the file, not the OS
NSRL-mapping.mdNSRLFileOpSystemCodesets source and target to the operating-system object. AdjacentProductCodeis source=file, target=product. This packet changes the source token on that one row.In:
NSRL-mapping.mdNSRLFileOpSystemCodecell only.Out:
ProductCode;SpecialCode; NSRL #38 ExternalID cells;NSRLFILE-mapping-example.md(already source=file / target=OS); a full NSRL remap; the catalog v0.1.0 pin.Review: that one cell against the
ProductCoderow above it.Validate: live L46 at
bf02e976is OS→OS. Example file already uses file→OS. No test suite on this repo.I am a volunteer. Thank you for the time. I am trying to become more useful on this work, so I welcome a critical look. If this is the wrong cut, or you want me to stand down, say so and I will recut from notes.