Skip to content

feat: Add connection pooling through shared singleton#48

Merged
joladev merged 1 commit into
masterfrom
use-connection-pool
Jan 16, 2019
Merged

feat: Add connection pooling through shared singleton#48
joladev merged 1 commit into
masterfrom
use-connection-pool

Conversation

@joladev

@joladev joladev commented Jan 10, 2019

Copy link
Copy Markdown
Contributor

Uses the requests.Sesson built in connection pool and shares it across instances using a singleton.

Fixes #19

@joladev joladev self-assigned this Jan 10, 2019
@joladev
joladev requested a review from nijikon January 10, 2019 10:00
@nijikon

nijikon commented Jan 11, 2019

Copy link
Copy Markdown
Contributor

@jprestel-rue we added connection pooling, feel free to review the PR

@jprestel-rue jprestel-rue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@joladev
joladev merged commit b8dde66 into master Jan 16, 2019
@joladev
joladev deleted the use-connection-pool branch January 16, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants