Analyser unit check raises the multiplier of a unit to its exponent, in contrast to the specification and Units::scalingFactor

[agarny]

Fixes #1463.

[Copilot]

Copilot review overview

🟡 Changes recommended

A critical analyser recursion issue can still double-count inherited multipliers.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

• Avoid applying inherited unit multipliers once per recursive child · New

What changed in this PR

Fixes unit-scaling behavior so multipliers and prefixes are handled correctly outside unit exponents.

Changes:

• Corrects unit scaling and analyser multiplier calculations.
• Adds regression tests and updates expected diagnostics.

File	Reviewed changes
tests/​units/​units.cpp	Adds scaling-factor regression tests.
tests/​analyser/​analyserunits.cpp	Adds analyser regression tests and updates expectations.
src/​units.cpp	Corrects custom-unit prefix scaling.
src/​analyser.cpp	Corrects analyser multiplier handling.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🔵 Needs a closer look

Validator unit-equivalence scaling still uses the outdated traversal and needs to be updated.

Review effort: Lite
Findings: None

Resolved since last review (1)

• Avoid applying inherited unit multipliers once per recursive child

[Copilot]

Copilot review overview

🟢 Approval recommended

All reviewed changes are covered by regression tests with no unresolved blocking issues.

Review effort: Lite
Findings: None

[Copilot]

Copilot review overview

🟢 Approval recommended

The only remaining finding is a minor test-coverage nit that does not block approval.

Review effort: Lite
Findings: None