fix: modify set account relation validation#713
Merged
Conversation
actually check fields are included and require content exists on data events
dav1do
force-pushed
the
fix/account-relations-validation
branch
from
April 11, 2025 14:23
2522060 to
77c0a46
Compare
dav1do
commented
Apr 11, 2025
dav1do
force-pushed
the
fix/account-relations-validation
branch
from
April 11, 2025 22:36
a07210f to
b2260fd
Compare
dav1do
force-pushed
the
fix/account-relations-validation
branch
from
April 11, 2025 22:37
b2260fd to
b7a5b9d
Compare
dav1do
enabled auto-merge
April 11, 2025 23:02
This was referenced May 26, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now check required fields are used to set
uniqueheader, and requirecontentexists on data events. We don't handle set fields that are objects, arrays.. we could, the js code appears to use[object Object]for objects so it'd be broken and we would need to support that.