Give both cron-included and non-cron-included users instructions on how to test using --dry-run#718
Merged
Merged
Conversation
…ow to test using --dry-run
alexzorin
reviewed
Jun 1, 2021
alexzorin
left a comment
Collaborator
There was a problem hiding this comment.
- Given that our example use case for directory hooks is haproxy, it's a little odd that selecting
haproxy/piporhaproxy/snapddoesn't show these instructions. Probably just due to the design of the generator. - Are we putting the
--dry-runinstructions below the "directory hooks" instructions intentionally? My first reaction was that it takes a lot of reading to get to it. On the other hand, if it's important for the user to read all that, maybe it's fine as it is.
Contributor
Author
|
Contributor
Author
|
Well, now it looks a little weird that we're saying "if your webserver is haproxy" when we do know it is, I can fix that. |
Contributor
Author
|
travis?? |
eaf5e77 to
aaef367
Compare
Contributor
Author
|
Updated screenshots in the top picture. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out here, we weren't showing users who needed to set up automatic renewal how to test their renewal setup. We should do that. Also, now that we always have users use directory hooks, we should have them test after they've set up the hooks.
Snap, apache (no certonly)

Snap, none of the above (certonly)

Snap, haproxy (certonly)

Pip, apache (no certonly)

Pip, none of the above (certonly)

Pip, haproxy (certonly)
