Skip to content

WIP ENT-3756: try to flush each line of logging while in debug level #3112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
craigcomstock wants to merge 1 commit into from
Closed

WIP ENT-3756: try to flush each line of logging while in debug level #3112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions libutils/logging.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,12 @@ static void LogToConsole(const char *msg, LogLevel level, bool color)

fprintf(stdout, "%8s: %s\n", LogLevelToString(level), msg);

if (level == LOG_LEVEL_DEBUG)
{
fflush(stdout);
// TODO also possibly call sync()? Not sure if that's too "expensive" or not.

@vpodzime vpodzime Aug 17, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think fsync() should be no problem, it's a debug mode after all.

}

if (color)
{
// Turn off the color again.
Expand Down