Skip to content

cfengine format ./examples/#6197

Closed
olehermanse wants to merge 3 commits into
cfengine:masterfrom
olehermanse:examples
Closed

cfengine format ./examples/#6197
olehermanse wants to merge 3 commits into
cfengine:masterfrom
olehermanse:examples

Conversation

@olehermanse

@olehermanse olehermanse commented Jun 26, 2026

Copy link
Copy Markdown
Member

No description provided.

@olehermanse olehermanse marked this pull request as ready for review June 26, 2026 22:14
@olehermanse

olehermanse commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

@cf-bottom jenkins

@cf-bottom

cf-bottom commented Jun 26, 2026

Copy link
Copy Markdown

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/14039/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14039/

@aleksandrychev aleksandrychev mentioned this pull request Jun 29, 2026
Closed
@olehermanse

olehermanse commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

@cf-bottom jenkins, please

@cf-bottom

cf-bottom commented Jun 29, 2026

Copy link
Copy Markdown

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/14056/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14056/

@olehermanse olehermanse requested a review from nickanderson June 29, 2026 21:37
@olehermanse
cfengine format ./examples/
20f0166 
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
@olehermanse
Adjusted test expectation after formatting
0d82f06 
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
@olehermanse

olehermanse commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

@cf-bottom jenkins, please

@cf-bottom

cf-bottom commented Jun 29, 2026

Copy link
Copy Markdown

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/14058/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14058/

@olehermanse olehermanse requested a review from larsewi June 29, 2026 23:16
nickanderson
nickanderson requested changes Jun 30, 2026
View reviewed changes

@nickanderson nickanderson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be messing up some #@ annotations

Comment thread examples/arrays.cf
Comment thread examples/customize_by_named_list.cf
Comment thread examples/filesize.cf
Comment thread examples/create_filedir.cf Outdated
@olehermanse
Manual edits after code review
caf5e3d 
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
@olehermanse olehermanse requested a review from nickanderson June 30, 2026 20:35
@olehermanse

olehermanse commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

@cf-bottom jenkins, please

@cf-bottom

cf-bottom commented Jun 30, 2026

Copy link
Copy Markdown

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/14068/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14068/

nickanderson
nickanderson approved these changes Jun 30, 2026
View reviewed changes

@nickanderson nickanderson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked the annotation ability.

@olehermanse olehermanse mentioned this pull request Jul 1, 2026
Merged
@olehermanse olehermanse closed this Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickanderson nickanderson nickanderson approved these changes
@larsewi larsewi Awaiting requested review from larsewi

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olehermanse @cf-bottom @nickanderson