Update to changesets v3 packages - #673
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 557354c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Closed
Andarist
approved these changes
Jun 25, 2026
Andarist
enabled auto-merge
June 25, 2026 10:57
Merged
Merged
qwerzl
added a commit
to photon-hq/spectrum-convex
that referenced
this pull request
Aug 22, 2026
The 0.1.1 release reached npm but produced no git tag and no GitHub release,
and the job still reported success.
`changesets/action@v1` works out what shipped by regex-scraping the publish
script's stdout:
/New tag:\s+(@[^/]+\/[^@]+|[^/]+)@([^\s]+)/
`@changesets/cli` v3 — which this repo has used since releases were automated —
prints `Successfully published:` instead. Nothing matched, so the action saw an
empty published-packages list, concluded there was nothing to release, and
skipped both the tag push and the GitHub release. Because it had not *failed*
at anything, the step exited zero.
v2 takes the release list from changesets rather than parsing its output
("Update to Changesets v3 packages", changesets/action#673). It also renames
every input, hence the rewritten step, and drops support for passing a token
via the `GITHUB_TOKEN` environment variable in favour of the `github-token`
input, which defaults to `github.token`. `create-github-releases` and
`push-git-tags` both default to true.
Worth noting v2 also removed its own `.npmrc` handling and now expects trusted
publishing, which is already how this repo authenticates.
The two tags the runner created and discarded are restored: v0.1.0 on d23891d,
the commit that was HEAD when 0.1.0 was published by hand, and v0.1.1 on the
version-packages commit. Both have GitHub releases carrying their changelog
sections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.