Fix resource endpoints checking for 'payload' in response - #8
Open
Skipants wants to merge 1 commit into
Open
Conversation
HTTPClient.get/patch/etc. already calls _unwrap_response on the JSON responses from the Chatwoot API, causing the methods in chatwoot/resources/ to have redundant checks at best and be broken at worst. AI Disclosure: Claude found and fixed this issue. They were audited manually by me and I stripped a lot of the crappy Claude comments it tried to add.
Skipants
force-pushed
the
fix-broken-inbox-members-resource
branch
from
July 30, 2026 21:50
bf3f1bb to
b8b5fc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTPClient.get/patch/etc. already calls _unwrap_response on the JSON responses from the Chatwoot API, causing the methods in chatwoot/resources/ to have redundant checks at best and be broken at worst.
AI Disclosure: Claude found and fixed this issue. They were audited manually by me and I stripped a lot of the crappy Claude comments it tried to add.