Skip to content

Feat telescope support to list marks - #106

Open
ValJed wants to merge 11 commits into
chentoast:masterfrom
ValJed:feat-telescope-support-for-listing-marks
Open

Feat telescope support to list marks#106
ValJed wants to merge 11 commits into
chentoast:masterfrom
ValJed:feat-telescope-support-for-listing-marks

Conversation

@ValJed

@ValJed ValJed commented Feb 27, 2024

Copy link
Copy Markdown

👋🏼

I was a bit frustrated when searching in my existing marks (I often lose myself). So I thought that a telescope extension would be a perfect fit for that (fuzzy finding, location preview).

I added two methods that return the right data for buffer marks and project marks as well as two telescope extensions that allow to get the current buffer marks and the project marks.

It looks like this for the buffer one:

image

And like this for the list all marks:

image

I named the extension marks_nvim because I had weird errors with marks that could be linked to possible conflicts.

Anyway, I hope it'll be useful to some and tanks for the great plugin!

@ctorney

ctorney commented Mar 1, 2024

Copy link
Copy Markdown

this is great - is it possible to list bookmarks as well?

@ValJed

ValJed commented Mar 3, 2024

Copy link
Copy Markdown
Author

@ctorney I'm not familiar with bookmarks, but should be doable I suppose.
I'll add it!

@ValJed
ValJed force-pushed the feat-telescope-support-for-listing-marks branch from ba9d003 to 0fe9ed8 Compare March 3, 2024 20:34
@ValJed
ValJed force-pushed the feat-telescope-support-for-listing-marks branch from 28797af to 8af9bae Compare March 5, 2024 19:30
@ValJed
ValJed force-pushed the feat-telescope-support-for-listing-marks branch from 8af9bae to e0f3229 Compare March 5, 2024 19:31
Comment thread lua/marks/bookmark.lua

return items
end

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real changes are only in this hunk, rest is linting.

@ValJed

ValJed commented Mar 5, 2024

Copy link
Copy Markdown
Author

@ctorney Done it now also supports bookmarks listing. See readme.

@ctorney

ctorney commented Mar 8, 2024

Copy link
Copy Markdown

Thanks @ValJed! Works perfectly

tylerw added a commit to tylerw/marks.nvim that referenced this pull request Oct 21, 2024
@dangkhoipro

Copy link
Copy Markdown

I wonder when this pull request is merged into master?

@pidgeon777

Copy link
Copy Markdown

I wonder when this pull request is merged into master?

I'm also wondering the same thing.

@ValJed

ValJed commented Dec 9, 2024

Copy link
Copy Markdown
Author

Me too ahah.

@dangkhoipro @pidgeon777
I'm using my branch since to be able to use the feature, you can by using my fork:

	{
		"ValJed/marks.nvim",
		branch = "feat-telescope-support-for-listing-marks",
                ...
         }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants