Repository navigation
Sailing: fix Barracuda trial interactions and route handling - #556
MuffinKid23 wants to merge 3 commits into
Conversation
|
Additional requested route refinement: final Marlin lap now passes through (3037,2761,0), with a one-tile arrival tolerance and protection from rapid retargeting. Targeted local compilation passed; this last waypoint change still needs live confirmation. Other behavior is unchanged. |
chsami
left a comment
There was a problem hiding this comment.
Reviewed head 5086f79.
P1: TrialAutomation.handleRum permanently returns true after four unacknowledged attempts while pendingRum remains set. TrialsScript.run then returns before navigateToWaypoint on every iteration, including when the interaction target has unloaded/moved outside 12 tiles. The diagnostic says to reposition or restart, but the automatic route can never reposition itself. Add a bounded recovery state that releases navigation/reacquires a valid interaction target (or explicitly stops the automation), and test missed acknowledgements, target loss, and retry exhaustion.
The plugin descriptor has no version bump, and TrialAutomationTest is only a main-method harness, so Gradle test does not execute its checks. Bump the version, wire these cases into executable tests, and rebase/target development with a public-client build. No additional live test is required for this review.
Summary
Validation
The user has confirmed the current version works in game and requested review. Targeted Java 11 compilation against the local customized Microbot 2.6.22 client passed. Thirteen standalone logic checks passed earlier in development; these are not a full integration or CI test suite. Public-client compatibility and repository CI remain for verification; local compilation is not represented as a public-client build result.
Scope
Only six Sailing source/test files are included. No Courier prototype, other plugins, logs, account details, or personal configuration files. Startup automation currently targets Tempor Tantrum; this does not claim complete Jubbly Jive or Gwenith Glide automation.