Skip to content

Sailing: fix Barracuda trial interactions and route handling - #556

Open
MuffinKid23 wants to merge 3 commits into
chsami:mainfrom
MuffinKid23:codex/sailing-barracuda-fixes
Open

MuffinKid23 wants to merge 3 commits into
chsami:mainfrom
MuffinKid23:codex/sailing-barracuda-fixes

Conversation

@MuffinKid23

@MuffinKid23 MuffinKid23 commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Start Tempor Tantrum using Start-trial and the configured Target Rank, rather than the previous rank.
  • Collect and deliver rum across boat world views, using HUD confirmation and bounded retries.
  • Activate rum interactions within 12 tiles, with no added tick delay. Existing retry throttling remains.
  • Use calmer keyboard camera yaw/pitch corrections, with shorter holds and less frequent adjustments.
  • Disable automatic trim for all trial routes; remove the experimental 20-second exception.
  • Keep original routes except three tested Marlin adjustments: first lap (3028,2815,0), second lap (3002,2788,0), final lap (3096,2775,0). Protect these waypoints from rapid retargeting.
  • Prefer Gentle rapids only close to the existing route; exclude the rapid near (3045,2774,0) on the final Marlin lap.
  • Guard missing boat entities, fix world-view unload iteration, and remove decorations only from their owning scene.
  • Give Trials precedence over Salvaging.

Validation

The user has confirmed the current version works in game and requested review. Targeted Java 11 compilation against the local customized Microbot 2.6.22 client passed. Thirteen standalone logic checks passed earlier in development; these are not a full integration or CI test suite. Public-client compatibility and repository CI remain for verification; local compilation is not represented as a public-client build result.

Scope

Only six Sailing source/test files are included. No Courier prototype, other plugins, logs, account details, or personal configuration files. Startup automation currently targets Tempor Tantrum; this does not claim complete Jubbly Jive or Gwenith Glide automation.

@MuffinKid23
MuffinKid23 marked this pull request as ready for review September 13, 2026 22:06
@MuffinKid23

Copy link
Copy Markdown
Contributor Author

Additional requested route refinement: final Marlin lap now passes through (3037,2761,0), with a one-tile arrival tolerance and protection from rapid retargeting. Targeted local compilation passed; this last waypoint change still needs live confirmation. Other behavior is unchanged.

@chsami chsami left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed head 5086f79.

P1: TrialAutomation.handleRum permanently returns true after four unacknowledged attempts while pendingRum remains set. TrialsScript.run then returns before navigateToWaypoint on every iteration, including when the interaction target has unloaded/moved outside 12 tiles. The diagnostic says to reposition or restart, but the automatic route can never reposition itself. Add a bounded recovery state that releases navigation/reacquires a valid interaction target (or explicitly stops the automation), and test missed acknowledgements, target loss, and retry exhaustion.

The plugin descriptor has no version bump, and TrialAutomationTest is only a main-method harness, so Gradle test does not execute its checks. Bump the version, wire these cases into executable tests, and rebase/target development with a public-client build. No additional live test is required for this review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants