Repository navigation
Add Dro Zulrah - #562
Add Dro Zulrah#562
Conversation
Implements the complete Zulrah trip loop: setup loading, travel, boat entry, rotation-aware combat, looting, Ferox recovery, and re-gearing. Supports hybrid switches or mage-only setups, prayer and gear management, venom-cloud routing, melee dodging, thralls, supported special attacks, and configurable smart breaks. Requires a saved Microbot Inventory Setup and a bank stocked with supplies, Zul-andra teleport scrolls, and a charged Ring of dueling. See README for details on BaseProfileDro and setup requirements. Includes focused tests for boat routing, safe movement, rotation recognition, prayer sequencing, melee dodging, and special-weapon behavior. The Zulrah source set compiled and the plugin JAR packaged successfully in Microbot-Hub. More than 25 in-game test runs covering fights, travel, banking, looting, and re-gearing succeeded; the plugin was refined throughout testing. Ready for live Hub review; this contribution targets development. Validation note: the Hub-wide test/build graph is blocked by unrelated existing compilation errors in Banksorter (missing ComponentID.BANK_TUTORIAL_BUTTON) and Tempoross (missing InterfaceID.TEMPOROSS). The focused Zulrah compile and JAR packaging passed; the complete automated test task could not be verified because it compiles the full Hub test tree.
… settings Keep the working combat/travel baseline and complete BaseProfileDro. Expose AFK/logout durations, interval bounds, logout probability and post-login settling. Keep ACTIVE/High mouse behavior without parking. Validated with 36 DroZulrah PR tests, plugin JAR packaging, and 14 additional local injection/prayer/config checks. Live gameplay of these additions is unverified.
chsami
left a comment
There was a problem hiding this comment.
Reviewed head 4ffe4ca597c6fd8dedb94b24eaa59cff850892f6. The PR only adds files under drozulrah/. The plugin source set compiles against client 2.6.26 (compileDrozulrahJava), and the 7 drozulrah test classes pass (36/36).
CI note, nothing for you to do here: the Hub development branch currently fails to compile against client 2.6.26 in unrelated plugins, so this PR's full-build CI will be red until development is updated.
P1: the descriptor is missing isExternal. DroZulrahPlugin.java:19-25 omits isExternal, which defaults to false (PluginDescriptor.isExternal() default false). MicrobotPluginManager only tracks loaded Hub plugins whose descriptor is external (lines 331, 371, 738 on development). DroZulrah is therefore never matched when the client syncs installed Hub plugins. Each refresh can load another instance, and uninstall or update never unloads the old one. Add enabledByDefault = PluginConstants.DEFAULT_ENABLED, isExternal = PluginConstants.IS_EXTERNAL, as the other Hub plugins (and your Dro KBD PR) do.
Non-blocking:
minClientVersion = "2.1.32"is much older than the client you built against (2.6.26). Please set it to the oldest client you actually verified.- The descriptor has no
authors/iconUrl/cardUrl, and the[Dro]prefix is hard-coded rather than added toPluginConstants. DroZulrahScript.java:57logsBUILD = "2.10.4-active-mouse"while the plugin version is1.10.7. Derive it from the version or drop it.
Declare external/default-disabled flags so Hub refresh, update and uninstall track the loaded plugin. Add shared Dro prefix, author and catalog assets; require verified client 2.6.26 and derive the startup label from the descriptor. Backed up 1.10.7 before editing. Microbot-Hub compilation, JAR packaging and 40 focused tests passed. No combat, travel, mouse or break behavior changes.
|
Addressed in commit
Verified in Microbot-Hub: scoped DroZulrah compilation, JAR packaging, and all 41 tests across 9 test classes passed. Image validation also passed without classpath resources. Combat, travel, mouse, and break behavior remain unchanged. |
chsami
left a comment
There was a problem hiding this comment.
Re-reviewed head ab58f8414a0c1d8e97cd678bf7a489a174dd8edb. The blocker is fixed: the descriptor now sets enabledByDefault and isExternal = true, and DroZulrahDescriptorTest checks the runtime annotation.
Also addressed:
minClientVersionis 2.6.26.- authors, iconUrl and cardUrl are set, and the docs assets publish to the matching path.
BUILDis derived from the descriptor version.
The embedded Base64 overlay images decode to the original PNGs. compileDrozulrahJava passes, the 41 drozulrah tests pass, and in isolation DroZulrahPlugin-1.10.8.jar contains only drozulrah classes. The diff touches only drozulrah/.
Optional follow-ups:
src/main/java/.../drozulrah/docs/duplicates the resources README and about 2.2 MB of PNGs that the build never uses.- README:135 says the prefix is in the shared
PluginConstants, but it is plugin-local now. - README:137 says 40 tests; there are 41.
Merge still waits on CI. Hub development doesn't currently compile against client 2.6.26 in unrelated plugins, so this PR's full-build check will be red until that is fixed. Nothing more is needed from you.
chsami
left a comment
There was a problem hiding this comment.
Re-reviewed head a7754f25: a docs-only follow-up that removes the duplicate src/main/java/.../drozulrah/docs copies and corrects the README notes (plugin-local PluginConstants, 41 tests). CI passed against the fixed development base (#566).
Summary
Adds Dro Zulrah 1.10.8 for RuneLite 1.13.1 / Microbot 2.6.26. The full trip workflow covers saved Inventory Setup loading, travel and boat entry, rotation-aware combat, looting, Ferox recovery and re-gearing. It supports hybrid or mage-only setups, gear and prayer management, venom-cloud routing, melee dodges, thralls and supported weapon specials.
Prayer toggles now open the prayer book, click the actual visible prayer button through BaseProfileDro and restore the previous tab. Missing, hidden or offscreen buttons are retried without a generic screen-sized click area. An optional Show Zulrah rotation helper checkbox adds current/next phases, recommended tiles, prayer indicators, countdown, instance timer and observed clouds. The display does not change the working combat movement or rotation logic.
The complete BaseProfileDro remains included with ACTIVE mouse behavior and High mouse speed. Parking and native offscreen/random mouse movement remain disabled. Its own smart-break handler now exposes all break controls in config: minimum/maximum intervals, AFK durations, logout durations, logout probability and post-login settling. Breaks begin only at Ferox between trips. Defaults preserve the previous policy; 0% logout selects AFK-only breaks and 100% selects logout-only breaks.
Requires a saved Microbot Inventory Setup and a stocked bank with supplies, Zul-andra teleport scrolls and a charged Ring of dueling. See the Hub resource README for setup, break settings and helper credits.
DroZulrah is explicitly marked as an external Hub plugin and disabled by default so installed-plugin refresh, update and uninstall can track its loaded instance. The display name remains
[Dro] Zulrah; the package-local descriptor constants, author and catalog assets are supplied. The startup log version derives from the descriptor, and the minimum client is the verified 2.6.26. This metadata correction leaves combat, travel, mouse and break behavior unchanged.The complete
drozulrahJava source folder can be copied into a compatible Microbot client without a separate runtime resources folder or changes to sharedPluginConstants. Its three original phase PNGs are embedded as Java data, and descriptor constants live inside the package. The six unused helper PNG resources have been removed. Documentation and the matching gold-and-charcoal Zulrah card/icon live in Hub resources for catalog publishing; unused duplicate source-package copies have been removed. Standard Microbot and Inventory Setups APIs are still required.Gameplay footage
Watch actual Dro Zulrah bot footage — provided by the contributor.
Validation
This PR targets
development.