fix(telemetry): stop tracking the completion command - #417
Merged
Conversation
`clerk completion <shell>` is wired into shell rc files with `eval`, so it re-runs on every new shell rather than when a user asks for it. It was 34.7% of all CLI telemetry over the last 14 days (19,436 of 55,994 events), 98% of it from a single machine, and 60% of one day's volume — enough to swing every command-mix and volume chart. `__complete` (fired on each Tab press) already exits in cli.ts before Commander runs, so it never emitted events. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 943b47c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Caution Review failedAn error occurred during the review process. Please try again later. Comment |
- restore an argv-leak assertion on a *sent* event (the driver swap dropped the only one): the invalid --mode test now asserts "banana" never appears - make the completion suppression test discriminate: it asserted zero requests on the first-run grace path, where nothing sends anyway, so it passed with the guard removed — it now also runs past the notice - collapse the one-entry UNTRACKED_COMMANDS set to a direct comparison - drive `webhooks token --json` in telemetry tests to skip outro's animation - drop the unit test the integration test strictly covers - note the completion exception in the module docstring Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
wyattjoh
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clerk completion <shell>is wired into shell rc files witheval, so it re-runs on every new shell instead of when a user asks for it. Its events measure shell startups, not CLI usage.Last 14 days in
clerk_telemetry.events(test machine excluded):completionwas the Bootstrap Clerk CLI with auth flow #1 command by volume: 19,436 of 55,994 events (34.7%) — ahead ofapi(25.9%)59a6b836…) sent 98.2% of them (12,356 in a single day)Change:
startCommandTelemetryskipscompletion, so no event and no first-run disclosure notice on a shell-startup run.__complete(each Tab press) already exits incli.tsbefore Commander, so it never emitted events.Telemetry integration tests used
clerk completion zshas their sample command; they now driveclerk webhooks token(also offline and auth-free).Data
🤖 Generated with Claude Code