Skip to content

fix(shared): Remove testUtils & smaller updates #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LekoArts merged 7 commits into from
Oct 12, 2023
Merged

fix(shared): Remove testUtils & smaller updates #1868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
234a01a
chore(shared): Smaller package.json maintenance
LekoArts Oct 12, 2023
6c209ea
chore(repo): Remove testUtils from shared pkg
LekoArts Oct 12, 2023
98e0a0b
chore(shared): Use correct testRegex
LekoArts Oct 12, 2023
02a239e
fix(shared): Remove nested package.json files in dist
LekoArts Oct 12, 2023
31c43dd
chore(repo): Update lock file
LekoArts Oct 12, 2023
cd52b26
Create serious-meals-wink.md
LekoArts Oct 12, 2023
b5955bb
Merge branch 'main' into cleanup/shared-test-utils
LekoArts Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/serious-meals-wink.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@clerk/shared": patch

@dimkl dimkl Oct 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 I think that changing the public API (eg removing an export in our case) of a package requires a major version bump.

@LekoArts LekoArts Oct 12, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an internal package without a README only used by our Jest tests that we also don't tell people to install or use. It'd consider it purely internal.

So while technically you're correct, I wouldn't care about that :)

---

Internal updates and improvements, with the only public change that npm should no longer complain about missing `react` peerDependency.

Updates:
- Remove `@clerk/shared/testUtils` export (which was only used for internal usage)
- Add `peerDependenciesMeta` to make `react` peerDep optional
Loading